Skip to content

MMC + FatFS fixes #89308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2025
Merged

MMC + FatFS fixes #89308

merged 2 commits into from
Apr 30, 2025

Conversation

kartben
Copy link
Collaborator

@kartben kartben commented Apr 30, 2025 •
edited
Loading

makes west twister --all -s sample.filesystem.fat_fs --no-detailed-test-id pass (vs. 2 failures before this PR)

kartben added 2 commits April 30, 2025 11:27
@kartben
boards: mm_feather: add missing mmc node
2b339fa 
Add missing mmc node to the mm_feather board, and properly
set disk-name for it.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben
fatfs: add support for mmc disks when generating FF_VOLUME_STRS
209eab1 
add zephyr,mmc-disk's disk names as they were missing causing fatfs to
be unusable on boards that had otherwise valid DT configuration for
the mmc disks.

Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
@kartben kartben marked this pull request as ready for review April 30, 2025 09:49
@kartben kartben requested review from butok and de-nordic April 30, 2025 09:49
@kartben kartben added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Apr 30, 2025
@github-actions github-actions bot added the area: Storage Storage subsystem label Apr 30, 2025
@kartben kartben mentioned this pull request Apr 30, 2025
Closed
@kartben kartben requested a review from danieldegrasse April 30, 2025 10:06
@kartben
Copy link
Collaborator Author

kartben commented Apr 30, 2025

@de-nordic does this look ok to you?

de-nordic
de-nordic approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@de-nordic de-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@de-nordic
Copy link
Collaborator

de-nordic commented Apr 30, 2025 •
edited
Loading

@de-nordic does this look ok to you?

Yes. Thanks.

FYI @JordanYates .

@kartben kartben merged commit 6c788e1 into zephyrproject-rtos:main Apr 30, 2025
36 checks passed
@kartben kartben deleted the sdmmc_fatfs_fixes branch May 7, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butok butok butok approved these changes

@de-nordic de-nordic de-nordic approved these changes

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

Assignees

@de-nordic de-nordic

Labels
area: Storage Storage subsystem Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sample: fs_sample: Build is failed for the sample.filesystem.fat_fs test case for the mm_feather board.
3 participants
@kartben @de-nordic @butok