Skip to content

samples: fs_sample: avoid CI fail for mm_feather #89304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

butok
Copy link
Collaborator

@butok butok commented Apr 30, 2025

- Avoid CI fail for the mm_feather board.
- Exclude the mm_feather board from sample.filesystem.fat_fs test case.

Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
@de-nordic
Copy link
Collaborator

Why was it failing?

@butok
Copy link
Collaborator Author

butok commented Apr 30, 2025

Why was it failing?

I would ask why CI has these breaches.

The CI fail:
https://github.com/zephyrproject-rtos/zephyr/actions/runs/14730557223/job/41343726538?pr=89257

@kartben
Copy link
Collaborator

kartben commented Apr 30, 2025

I agree with @de-nordic -- removing without documenting why it needs to be excluded is really not ideal

@kartben
Copy link
Collaborator

kartben commented Apr 30, 2025

the proper fix is that the usdhc1 node should have the following children, I think?

	mmc {
		compatible = "zephyr,sdmmc-disk";
		disk-name = "SD";
		status = "okay";
	};

@butok
Copy link
Collaborator Author

butok commented Apr 30, 2025

I agree with @de-nordic -- removing without documenting why it needs to be excluded is really not ideal

#89305 hope, it's enough.

@butok
Copy link
Collaborator Author

butok commented Apr 30, 2025

the proper fix is that the usdhc1 node should have the following children, I think?

	mmc {
		compatible = "zephyr,sdmmc-disk";
		disk-name = "SD";
		status = "okay";
	};

Better to ask a maintainer/owner of the "madmachine" boards, but I cannot find it in the MINTAINERS.yml.
Is it OK, to have boards without a maintainer?

For now, we need to unblock CI.

@kartben
Copy link
Collaborator

kartben commented Apr 30, 2025

For now, we need to unblock CI.

No need to use big bold characters, please :)
I believe both @de-nordic and I are trying to help address this, and also find the root cause.

Test is failing for mimxrt595_evk_mimxrt595s_cm33 as well so if the goal is to unblock CI we need a better/more complete fix anyway, and or identify the commit that introduced the regression and consider reverting it.

@kartben
Copy link
Collaborator

kartben commented Apr 30, 2025

Sending a fix shortly

@butok
Copy link
Collaborator Author

butok commented Apr 30, 2025

Closing, as it will be a better fix.

@butok butok closed this Apr 30, 2025
@kartben
Copy link
Collaborator

kartben commented Apr 30, 2025

Sending a fix shortly

see #89308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants