-
Notifications
You must be signed in to change notification settings - Fork 7.3k
samples: fs_sample: avoid CI fail for mm_feather #89304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
butok
commented
Apr 30, 2025
•
edited
Loading
edited
- Avoid CI fail for the mm_feather board sample: fs_sample: Build is failed for the sample.filesystem.fat_fs test case for the mm_feather board. #89305.
- Exclude the mm_feather board from sample.filesystem.fat_fs test case.
- Avoid CI fail for the mm_feather board. - Exclude the mm_feather board from sample.filesystem.fat_fs test case. Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
Why was it failing? |
I would ask why CI has these breaches. The CI fail: |
I agree with @de-nordic -- removing without documenting why it needs to be excluded is really not ideal |
the proper fix is that the usdhc1 node should have the following children, I think?
|
#89305 hope, it's enough. |
Better to ask a maintainer/owner of the "madmachine" boards, but I cannot find it in the MINTAINERS.yml. For now, we need to unblock CI. |
No need to use big bold characters, please :) Test is failing for mimxrt595_evk_mimxrt595s_cm33 as well so if the goal is to unblock CI we need a better/more complete fix anyway, and or identify the commit that introduced the regression and consider reverting it. |
Sending a fix shortly |
Closing, as it will be a better fix. |
see #89308 |