Skip to content

enum class rr_type #3001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 28, 2025
Merged

enum class rr_type #3001

merged 13 commits into from
Apr 28, 2025

Conversation

soheilshahrouz
Copy link
Contributor

Opened to trigger CI.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool lang-cpp C/C++ code labels Apr 24, 2025
@soheilshahrouz
make format
eb54502 
enum class e_rr_type
a few remaining t_rr_type vals
CHANY ---> t_rr_type::CHANY
CHANX ---> t_rr_type::CHANX
OPIN ---> t_rr_type::OPIN
IPIN ---> t_rr_type::IPIN
SINK ---> t_rr_type::SINK
SOURCE ---> t_rr_type::SOURCE
@soheilshahrouz soheilshahrouz force-pushed the temp_enum_class_rr_type branch from 054e1be to eb54502 Compare April 24, 2025 21:27
amin1377
amin1377 requested changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Soheil! Thanks!

I talked to Soehil and he mentioned that he is going to remove t_rr_type completely and replace it with e_rr_type.

amin1377
amin1377 approved these changes Apr 26, 2025
View reviewed changes
Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Soheil! The PR looks good.

AmirhosseinPoolad
AmirhosseinPoolad requested changes Apr 26, 2025
View reviewed changes
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation for the new vtr::array container in the API reference.
https://docs.verilogtorouting.org/en/latest/api/vtrutil/containers/

@github-actions github-actions bot added the docs Documentation label Apr 27, 2025
@AmirhosseinPoolad AmirhosseinPoolad merged commit 80604ef into master Apr 28, 2025
36 checks passed
@AlexandreSinger AlexandreSinger deleted the temp_enum_class_rr_type branch April 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amin1377 amin1377 amin1377 approved these changes

@AmirhosseinPoolad AmirhosseinPoolad AmirhosseinPoolad approved these changes

Assignees
No one assigned
Labels
docs Documentation lang-cpp C/C++ code libvtrutil VPR VPR FPGA Placement & Routing Tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soheilshahrouz @amin1377 @AmirhosseinPoolad