support private endpoints

[whoffler]

Description

support private endpoints

for issue - #444 (comment)

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[whoffler]

/run pipeline

[ocofaigh]

1 comment - will be interesting to see how upgrade test reacts to this change. Hopefully its an update in place

[whoffler]

/run pipeline

[ocofaigh]

I expected the upgrade test to fail, but it passes. So I checked the code, and seem the wrong test function is being used for the upgrade test. Its using RunSchematicTest and it should be using RunSchematicUpgradeTest:

err := options.RunSchematicUpgradeTest()
if !options.UpgradeTestSkipped {
  assert.Nil(t, err, "This should not have errored")
}

Please fix the upgrade test

[whoffler]

Ran upgrade test locally and it fails:

Error:      	Should be false
        	Test:       	TestRunSecurityEnforcedUpgradeDASolution
        	Messages:   	Resource(s) identified to be updated 
        	            	Name: en_instance
        	            	Address: module.event_notifications.module.event_notifications[0].ibm_resource_instance.en_instance
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{"parameters":{"service-endpoints":"public-and-private"}}
        	            	  After: 
        	            		{"parameters":{"service-endpoints":"private"}}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
                                  "after": {
        	            	    "parameters": {
        	            	      "service-endpoints": "private"
        	            	    },
                                     ...
        	            	    "service": "event-notifications",
        	            	    "service_endpoints": "public-and-private",
        	            	  ...
                                  "before": {
        	            	    "parameters_json": null,
        	            	    "plan": "standard",
        	            	    "service": "event-notifications",
        	            	    "service_endpoints": "public-and-private",

[whoffler]

/run pipeline

[whoffler]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

• GitHub release
• v2.2.0

Your semantic-release bot 📦🚀