SKIP UPGRADE TEST update upgrade test

whoffler · whoffler · commit 5df337c15ea2 · 2025-05-13T14:31:20.000+01:00
diff --git a/tests/pr_test.go b/tests/pr_test.go
@@ -314,7 +314,9 @@ func TestRunSecurityEnforcedUpgradeDASolution(t *testing.T) {
 		{Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"},
 	}
 	err := options.RunSchematicUpgradeTest()
-	assert.NoError(t, err, "TestRunSecurityEnforcedUpgradeDASolution using existing RG, KMS and COS Failed")
+	if !options.UpgradeTestSkipped {
+		assert.Nil(t, err, "This should not have errored")
+	}
 }
 
 func TestRunExistingResourcesInstances(t *testing.T) {

Original file line number	Diff line number	Diff line change
`@@ -314,7 +314,9 @@ func TestRunSecurityEnforcedUpgradeDASolution(t *testing.T) {`
`314`	`314`	`{Name: "existing_cos_instance_crn", Value: permanentResources["general_test_storage_cos_instance_crn"], DataType: "string"},`
`315`	`315`	`}`
`316`	`316`	`err := options.RunSchematicUpgradeTest()`
`317`		`- assert.NoError(t, err, "TestRunSecurityEnforcedUpgradeDASolution using existing RG, KMS and COS Failed")`
	`317`	`+ if !options.UpgradeTestSkipped {`
	`318`	`+ assert.Nil(t, err, "This should not have errored")`
	`319`	`+ }`
`318`	`320`	`}`
`319`	`321`
`320`	`322`	`func TestRunExistingResourcesInstances(t *testing.T) {`