Skip to content

Fix child_frame_id in controller_state_msg #1601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ const control_msgs::msg::AdmittanceControllerState & AdmittanceRule::get_control
state_message_.admittance_position = tf2::eigenToTransform(admittance_state_.admittance_position);

state_message_.ref_trans_base_ft.header.frame_id = parameters_.kinematics.base;
state_message_.ref_trans_base_ft.header.frame_id = "ft_reference";
state_message_.ref_trans_base_ft.child_frame = parameters_.ft_sensor.frame.id;
state_message_.ref_trans_base_ft = tf2::eigenToTransform(admittance_state_.ref_trans_base_ft);

Eigen::Quaterniond quat(admittance_state_.rot_base_control);
Expand Down
20 changes: 20 additions & 0 deletions admittance_controller/test/test_admittance_controller.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,26 @@ TEST_F(AdmittanceControllerTest, publish_status_success)
// }
}

TEST_F(AdmittanceControllerTest, check_frame_ids_in_controller_state)
{
SetUpController();

ASSERT_EQ(controller_->on_configure(rclcpp_lifecycle::State()), NODE_SUCCESS);
ASSERT_EQ(controller_->on_activate(rclcpp_lifecycle::State()), NODE_SUCCESS);

broadcast_tfs(); // force torque sensor

ASSERT_EQ(
controller_->update(rclcpp::Time(0), rclcpp::Duration::from_seconds(0.01)),
controller_interface::return_type::OK);

const auto & msg = controller_->admittance_->get_controller_state();

// Ensure correct frame IDs
ASSERT_EQ(
msg.ref_trans_base_ft.header.frame_id, controller_->admittance_->parameters_.kinematics.base);
}

TEST_F(AdmittanceControllerTest, receive_message_and_publish_updated_status)
{
SetUpController();
Expand Down
Loading