Skip to content

Adjust demo notebooks path for guided notebooks PR check #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Jul 26, 2024

Issue link

What changes have been made

Adjusting demo notebooks path for guided notebooks PR check.
Also fixing broken links in readme.

Verification steps

Run Guided notebooks PR check.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@sutaakar sutaakar requested a review from KPostOffice July 26, 2024 13:48
@openshift-ci openshift-ci bot requested a review from MichaelClifford July 26, 2024 13:48
@sutaakar sutaakar added the test-guided-notebooks Run PR check to verify Guided notebooks label Jul 26, 2024
@sutaakar sutaakar added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Jul 26, 2024
@sutaakar sutaakar requested a review from Bobbins228 July 26, 2024 14:17
@sutaakar sutaakar added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Jul 26, 2024
@sutaakar sutaakar added test-guided-notebooks Run PR check to verify Guided notebooks and removed test-guided-notebooks Run PR check to verify Guided notebooks labels Jul 26, 2024
Copy link
Contributor

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2024
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, ChughShilpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9a8603d into project-codeflare:main Jul 29, 2024
13 checks passed
@sutaakar sutaakar deleted the guided-notebooks branch August 5, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. test-guided-notebooks Run PR check to verify Guided notebooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants