Skip to content

Commit 004daf0

Browse files
committed
Adjust demo notebooks path for guided notebooks PR check
1 parent 029683f commit 004daf0

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/guided_notebook_tests.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ jobs:
8787
sed -i "s/head_memory=2,/head_memory=2, namespace='default',/" 0_basic_ray.ipynb
8888
# Run notebook
8989
poetry run papermill 0_basic_ray.ipynb 0_basic_ray_out.ipynb --log-output --execution-timeout 600
90-
working-directory: demo-notebooks/guided-demos
90+
working-directory: src/codeflare_sdk/demo-notebooks/guided-demos
9191

9292
- name: Print CodeFlare operator logs
9393
if: always() && steps.deploy.outcome == 'success'
@@ -209,7 +209,7 @@ jobs:
209209
sed -i "s/head_cpus=1,/head_cpus=1, namespace='default',/" 1_cluster_job_client.ipynb
210210
# Run notebook
211211
poetry run papermill 1_cluster_job_client.ipynb 1_cluster_job_client_out.ipynb --log-output --execution-timeout 1200
212-
working-directory: demo-notebooks/guided-demos
212+
working-directory: src/codeflare_sdk/demo-notebooks/guided-demos
213213

214214
- name: Print CodeFlare operator logs
215215
if: always() && steps.deploy.outcome == 'success'
@@ -344,7 +344,7 @@ jobs:
344344
poetry run papermill 2_basic_interactive.ipynb 2_basic_interactive_out.ipynb --log-output --execution-timeout 1200
345345
env:
346346
GRPC_DNS_RESOLVER: "native"
347-
working-directory: demo-notebooks/guided-demos
347+
working-directory: src/codeflare_sdk/demo-notebooks/guided-demos
348348

349349
- name: Print CodeFlare operator logs
350350
if: always() && steps.deploy.outcome == 'success'

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ An intuitive, easy-to-use python interface for batch resource requesting, access
77

88
For guided demos and basics walkthroughs, check out the following links:
99

10-
- Guided demo notebooks available [here](https://github.com/project-codeflare/codeflare-sdk/tree/main/src/demo-notebooks/guided-demos), and copies of the notebooks with [expected output](https://github.com/project-codeflare/codeflare-sdk/tree/main/src/demo-notebooks/guided-demos/notebook-ex-outputs) also available
10+
- Guided demo notebooks available [here](https://github.com/project-codeflare/codeflare-sdk/tree/main/src/codeflare_sdk/demo-notebooks/guided-demos), and copies of the notebooks with [expected output](https://github.com/project-codeflare/codeflare-sdk/tree/main/src/codeflare_sdk/demo-notebooks/guided-demos/notebook-ex-outputs) also available
1111
- these demos can be copied into your current working directory when using the `codeflare-sdk` by using the `codeflare_sdk.copy_demo_nbs()` function
1212
- Additionally, we have a [video walkthrough](https://www.youtube.com/watch?v=U76iIfd9EmE) of these basic demos from June, 2023
1313

src/codeflare_sdk/demo-notebooks/guided-demos/2_basic_interactive.ipynb

+4-4
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@
6565
" head_gpus=1, # For GPU enabled workloads set the head_gpus and num_gpus\n",
6666
" num_gpus=1,\n",
6767
" num_workers=2,\n",
68-
" min_cpus=2,\n",
69-
" max_cpus=2,\n",
70-
" min_memory=8,\n",
71-
" max_memory=8,\n",
68+
" min_cpus='250m',\n",
69+
" max_cpus=1,\n",
70+
" min_memory=4,\n",
71+
" max_memory=6,\n",
7272
" # image=\"\", # Optional Field \n",
7373
" write_to_file=False, # When enabled Ray Cluster yaml files are written to /HOME/.codeflare/resources \n",
7474
" # local_queue=\"local-queue-name\" # Specify the local queue manually\n",

0 commit comments

Comments
 (0)