-
Notifications
You must be signed in to change notification settings - Fork 0
Dynawo simulation nordic case notebook #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Use network variant Display TCB simulation curve Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Thanks a lot @joyelfeghali for the comments in the notebook! 🙏 |
It's at 1.1s, after 0.1s after the fault occurred. I will correct it since it is not very clear. |
Also maybe we could plot the curves in seconds, not ms? |
Could you do this @Lisrte? |
All done, I also changed the axis label a little. |
any chance it could be launched on binder? Shouldn't we add the link anyway? We did it for dynaflow at least... |
Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
Replace automaton with automation system Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Mutualize plot configuration in plot function Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
bab16da
to
bb187a6
Compare
In order to have the proper DCO, I rebased the PR and pushed-force to add the missing signoff to your commits @joyelfeghali. I also added the link to the mybinder, pointing at current branch - this should be changed to main once the PR is reviewed (added do-not-merge label to not forget). |
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Feature
What is the current behavior?
What is the new behavior (if this is a feature change)?
Add a notebook for Dynawo dynamic simulation nordic case
Does this PR introduce a breaking change or deprecate an API?