Skip to content

Dynawo simulation nordic case notebook #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Lisrte
Copy link

@Lisrte Lisrte commented Dec 18, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

No

What kind of change does this PR introduce?

Feature

What is the current behavior?

What is the new behavior (if this is a feature change)?
Add a notebook for Dynawo dynamic simulation nordic case

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Use network variant
Display TCB simulation curve

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte self-assigned this Dec 18, 2024
@Lisrte Lisrte changed the title Dynawo simulation nordic case Dynawo simulation nordic case notebook Dec 18, 2024
@Lisrte Lisrte requested a review from flo-dup February 10, 2025 13:21
@flo-dup
Copy link

flo-dup commented Feb 11, 2025

Thanks a lot @joyelfeghali for the comments in the notebook! 🙏
Just one thing, isn't there a mistake on your description of the first curve? The events you mentioned at 30s and 35s don't correspond to the curve, it seems. And similarly when you say "0.1s later", it's not 100% clear to me where on the curve we are (0.1s after which event?)

@joyelfeghali
Copy link
Collaborator

Thanks a lot @joyelfeghali for the comments in the notebook! 🙏 Just one thing, isn't there a mistake on your description of the first curve? The events you mentioned at 30s and 35s don't correspond to the curve, it seems. And similarly when you say "0.1s later", it's not 100% clear to me where on the curve we are (0.1s after which event?)

It's at 1.1s, after 0.1s after the fault occurred. I will correct it since it is not very clear.
For the other events, it is not very visible at the curve but at 34s to be precise the LTC starts changing taps but before that, it seems that we arrived at a kind of equilibrium, where the rate of change of the voltage is very slow. I will also change the way I describe it.

@joyelfeghali
Copy link
Collaborator

Thanks a lot @joyelfeghali for the comments in the notebook! 🙏 Just one thing, isn't there a mistake on your description of the first curve? The events you mentioned at 30s and 35s don't correspond to the curve, it seems. And similarly when you say "0.1s later", it's not 100% clear to me where on the curve we are (0.1s after which event?)

It's at 1.1s, after 0.1s after the fault occurred. I will correct it since it is not very clear. For the other events, it is not very visible at the curve but at 34s to be precise the LTC starts changing taps but before that, it seems that we arrived at a kind of equilibrium, where the rate of change of the voltage is very slow. I will also change the way I describe it.

Also maybe we could plot the curves in seconds, not ms?

@flo-dup
Copy link

flo-dup commented Feb 11, 2025

Also maybe we could plot the curves in seconds, not ms?

Could you do this @Lisrte?

@Lisrte
Copy link
Author

Lisrte commented Feb 11, 2025

Also maybe we could plot the curves in seconds, not ms?

Could you do this @Lisrte?

All done, I also changed the axis label a little.

@flo-dup flo-dup mentioned this pull request Feb 11, 2025
@flo-dup
Copy link

flo-dup commented Feb 11, 2025

any chance it could be launched on binder? Shouldn't we add the link anyway? We did it for dynaflow at least...

joyelfeghali and others added 5 commits February 14, 2025 16:13
Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
Signed-off-by: Joy El Feghali <joy.elfeghali@rte-france.com>
Replace automaton with automation system

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Mutualize plot configuration in plot function

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup flo-dup force-pushed the dynawo_simulation_nordic_case branch from bab16da to bb187a6 Compare February 14, 2025 15:21
@flo-dup
Copy link

flo-dup commented Feb 14, 2025

In order to have the proper DCO, I rebased the PR and pushed-force to add the missing signoff to your commits @joyelfeghali.

I also added the link to the mybinder, pointing at current branch - this should be changed to main once the PR is reviewed (added do-not-merge label to not forget).

Signed-off-by: lisrte <laurent.issertial@rte-france.com>
@Lisrte Lisrte requested a review from flo-dup February 26, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants