Ibex bumped

vendor/lowrisc_ibex.lock.hjson

@@ -9,6 +9,6 @@
   upstream:
   {
     url: https://github.com/lowRISC/ibex.git
-    rev: c9f4a329636e59acb10647333badbb31bc7512b8
+    rev: 594ea976c9dad793f87edf91ec1c4c1df447e6dc
   }
 }

vendor/lowrisc_ibex/.svlint.toml

@@ -5,7 +5,7 @@
 # Rules for svlint, a SystemVerilog linter commonly used in editors.
 # The configuration matches the lowRISC SystemVerilog style guide at
 # https://github.com/lowRISC/style-guides/blob/master/VerilogCodingStyle.md.
-# See https://github.com/dalance/svlint/blob/master/RULES.md for a list of rules.
+# See https://github.com/dalance/svlint/blob/master/MANUAL.md for a list of rules.
 
 [option]
 exclude_paths = ["build.*", "sw/.*", ".sv.tpl$", "vendor/.*"]

vendor/lowrisc_ibex/NOTICE

@@ -0,0 +1,10 @@
+The Ibex Project
+Copyright 2024 lowRISC contributors.
+
+This product includes hardware and/or software developed as part of the
+Ibex(R) (https://github.com/lowRISC/ibex) and OpenTitan(R) projects.
+
+Ibex was originally developed by the PULP team at ETH Zurich and University of
+Bologna under the name zero-riscy. Ibex verification, performance enhancement
+and security hardening have been supported by the OpenTitan project
+(https://www.opentitan.org).

vendor/lowrisc_ibex/README.md

@@ -85,7 +85,7 @@ When contributing SystemVerilog source code, please try to be consistent and adh
 coding style guide](https://github.com/lowRISC/style-guides/blob/master/VerilogCodingStyle.md).
 
 When contributing C or C++ source code, please try to adhere to [the OpenTitan C++ coding style
-guide](https://docs.opentitan.org/doc/rm/c_cpp_coding_style/).
+guide](https://opentitan.org/book/doc/contributing/style_guides/c_cpp_coding_style.html).
 All C and C++ code should be formatted with clang-format before committing.
 Either run `clang-format -i filename.cc` or `git clang-format` on added files.
 

vendor/lowrisc_ibex/SECURITY.md

@@ -0,0 +1,8 @@
+# Reporting Security Issues
+
+The lowRISC team and Ibex community (including the OpenTitan partnership) take security issues seriously.
+
+We appreciate all efforts to find security vulnerabilities in Ibex and ask that responsible disclosure is practiced should you discover a potential vulnerability.
+
+As Ibex and in particular its secure configuration was developed as part of [OpenTitan](https://www.github.com/lowrisc/opentitan) contact [security@opentitan.org](mailto:security@opentitan.org) to report any security issues and do not open a public issue.
+[security@opentitan.org](mailto:security@opentitan.org) will advise on the coordinated vulnerability disclosure (CVD) procedure.

vendor/lowrisc_ibex/ci/install-build-deps.sh

@@ -26,7 +26,7 @@ if [ -z "$GITHUB_ACTIONS" ]; then
 fi
 
 case "$ID-$VERSION_ID" in
-  ubuntu-16.04|ubuntu-18.04|ubuntu-20.04)
+  ubuntu-20.04|ubuntu-22.04)
     # Curl must be available to get the repo key below.
     $SUDO_CMD apt-get update
     $SUDO_CMD apt-get install -y curl
@@ -60,14 +60,12 @@ case "$ID-$VERSION_ID" in
     $SUDO_CMD mkdir -p /tools/riscv-isa-sim
     $SUDO_CMD chmod 777 /tools/riscv-isa-sim
     $SUDO_CMD tar -C /tools/riscv-isa-sim -xvzf ibex-cosim-"$IBEX_COSIM_VERSION".tar.gz --strip-components=1
-    echo "##vso[task.prependpath]/tools/riscv-isa-sim/bin"
     echo "/tools/riscv-isa-sim/bin" >> $GITHUB_PATH
 
     wget https://storage.googleapis.com/verilator-builds/verilator-"$VERILATOR_VERSION".tar.gz
     $SUDO_CMD mkdir -p /tools/verilator
     $SUDO_CMD chmod 777 /tools/verilator
     $SUDO_CMD tar -C /tools/verilator -xvzf verilator-"$VERILATOR_VERSION".tar.gz
-    echo "##vso[task.prependpath]/tools/verilator/$VERILATOR_VERSION/bin"
     echo "/tools/verilator/$VERILATOR_VERSION/bin" >> $GITHUB_PATH
     # Python dependencies
     #
@@ -83,10 +81,11 @@ case "$ID-$VERSION_ID" in
     # Install Verible
     mkdir -p build/verible
     cd build/verible
-    curl -Ls -o verible.tar.gz "https://github.com/google/verible/releases/download/$VERIBLE_VERSION/verible-$VERIBLE_VERSION-Ubuntu-$VERSION_ID-$VERSION_CODENAME-x86_64.tar.gz"
-    $SUDO_CMD mkdir -p /tools/verible && $SUDO_CMD chmod 777 /tools/verible
-    tar -C /tools/verible -xf verible.tar.gz --strip-components=1
-    echo "##vso[task.prependpath]/tools/verible/bin"
+    VERIBLE_URL="https://github.com/chipsalliance/verible/releases/download/$VERIBLE_VERSION/verible-$VERIBLE_VERSION-linux-static-x86_64.tar.gz"
+    $SUDO_CMD mkdir -p /tools/verible
+    curl -sSfL "$VERIBLE_URL" | $SUDO_CMD tar -C /tools/verible -xvzf - --strip-components=1
+    # Fixup bin permission which is broken in tarball.
+    $SUDO_CMD chmod 755 /tools/verible/bin
     echo "/tools/verible/bin" >> $GITHUB_PATH
     ;;
 
@@ -101,6 +100,5 @@ TOOLCHAIN_URL="https://github.com/lowRISC/lowrisc-toolchains/releases/download/$
 mkdir -p build/toolchain
 curl -Ls -o build/toolchain/rv32-toolchain.tar.xz "$TOOLCHAIN_URL"
 $SUDO_CMD mkdir -p /tools/riscv && $SUDO_CMD chmod 777 /tools/riscv
-tar -C /tools/riscv -xf build/toolchain/rv32-toolchain.tar.xz --strip-components=1
-echo "##vso[task.prependpath]/tools/riscv/bin"
+$SUDO_CMD tar -C /tools/riscv -xf build/toolchain/rv32-toolchain.tar.xz --strip-components=1
 echo "/tools/riscv/bin" >> $GITHUB_PATH

vendor/lowrisc_ibex/ci/run-cosim-test.sh

@@ -4,7 +4,7 @@
 # SPDX-License-Identifier: Apache-2.0
 #
 # Run an elf against simple system co-simulation and check the UART output for
-# reported pass/fail reporting as appropriate for use in Azure pipelines
+# reported pass/fail reporting as appropriate for use in GitHub Actions
 
 SKIP_PASS_CHECK=0
 
@@ -26,14 +26,12 @@ fi
 echo "Running $TEST_NAME with co-simulation"
 build/lowrisc_ibex_ibex_simple_system_cosim_0/sim-verilator/Vibex_simple_system --meminit=ram,$TEST_ELF
 if [ $? != 0 ]; then
-  echo "##vso[task.logissue type=error]Running % failed co-simulation testing"
   echo "::error::Running % failed co-simulation testing"
   exit 1
 fi
 
 grep 'FAILURE' ibex_simple_system.log
 if [ $? != 1 ]; then
-  echo "##vso[task.logissue type=error]Failure seen in $TEST_NAME log"
   echo "::error::Failure seen in $TEST_NAME log"
   echo "Log contents:"
   cat ibex_simple_system.log
@@ -43,7 +41,6 @@ fi
 if [ $SKIP_PASS_CHECK != 1 ]; then
   grep 'PASS' ibex_simple_system.log
   if [ $? != 0 ]; then
-    echo "##vso[task.logissue type=error]No pass seen in $TEST_NAME log"
     echo "::error::No pass seen in $TEST_NAME log"
     echo "Log contents:"
     cat ibex_simple_system.log

vendor/lowrisc_ibex/ci/vars.env

@@ -5,11 +5,11 @@
 # Pipeline variables, used by the public and private CI pipelines
 # Quote values to ensure they are parsed as string (version numbers might
 # end up as float otherwise).
-VERILATOR_VERSION=v4.104
-IBEX_COSIM_VERSION=15fbd568
+VERILATOR_VERSION=v4.210
+IBEX_COSIM_VERSION=39612f9
 RISCV_TOOLCHAIN_TAR_VERSION=20220210-1
 RISCV_TOOLCHAIN_TAR_VARIANT=lowrisc-toolchain-gcc-rv32imcb
 RISCV_COMPLIANCE_GIT_VERSION=844c6660ef3f0d9b96957991109dfd80cc4938e2
-VERIBLE_VERSION=v0.0-2135-gb534c1fe
+VERIBLE_VERSION=v0.0-3622-g07b310a3
 # lowRISC-internal version numbers of Ibex-specific Spike builds.
 SPIKE_IBEX_VERSION=20220817-git-eccdcb15c3e51b4f7906c7b42fb824f24a4338a2