-
Notifications
You must be signed in to change notification settings - Fork 433
chore(Makefile): pin dependencies #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…et, adjust formatting
e47d0c2
to
fab7f9d
Compare
(finished with my experiments for now, so the PR should be OK to review) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the approach of a dedicated Toolchain makefile and simpler Action workflows!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the last comment below I think this looks good as is!
Co-authored-by: Steffen Baarsgaard <steff.bpoulsen@gmail.com>
Toolchain.mk
:Makefile
;setup-envtest
:crdoc
:kustomize
:darwin/arm64
build is used (previously, it would fall back todarwin/amd64
);chainsaw
,controller-gen
,setup-envtest
are now downloaded as binaries instead of relying ongo install
to speed up the installation process;/
->-
);test
target;test
target;There are plenty of things that can be further improved in Makefile, it should just be a good start.