chore(Makefile): pin dependencies (#2023)

* chore(Makefile): pin golangci-lint

* chore(Makefile): pin kustomize

* chore(Makefile): pin operator-sdk

* chore(Makefile): pin kind

* chore(Makefile): pin controller-gen

* chore(Makefile): pin ko

* chore(Makefile): pin yq

* chore(Makefile): pin crdoc

* chore(Makefile): pin chainsaw

* chore(Makefile): pin helm-docs

* chore(Makefile): pin opm

* chore(Makefile): pin envtest

* chore(Makefile): add set -e

* chore(Makefile): deprecate LOCALBIN

* chore(Makefile): reorder tools

* chore(Makefile): add phony for api-docs

* fix(workflows): move kustomize overlay validation to Makefile

* chore(Makefile): pin envtest to 0.20

* chore(Makefile): pin kustomize in release workflow

* chore(workflows): remove unused chainsaw and ko binaries from e2e

* chore(Makefile): pin helm for lint step and make it part of test target

* chore(Makefile): switch to bash for helm installation

* chore(Makefile): rename some targets to make them appear in help target, adjust formatting

* chore(Makefile): fix crdoc command

* chore(Makefile): indicate when a tool is being installed

* chore(Makefile): download setup-envtest as binary

* chore(Makefile): download controller-gen as binary

* chore(Makefile): bump kustomize to v5.6.0, so native Darwin version is used

* chore(Makefile): download chainsaw as binary

* fix(Makefile): make $(BIN) order-only-prerequisite and remove ifeq

* fix(Makefile): make all default target

* fix(Makefile): start-kind calls

Co-authored-by: Steffen Baarsgaard <steff.bpoulsen@gmail.com>

---------

Co-authored-by: Steffen Baarsgaard <steff.bpoulsen@gmail.com>

Author: weisdd

.github/workflows/e2e.yaml

@@ -63,14 +63,6 @@ jobs:
           go-version-file: "go.mod"
           cache: true
 
-      - name: Install ko
-        uses: ko-build/setup-ko@d006021bd0c28d1ce33a07e7943d48b079944c8d # v0.9
-        with:
-          version: v0.16.0
-
-      - name: Install chainsaw
-        uses: kyverno/action-install-chainsaw@f2b47b97dc889c12702113753d713f01ec268de5 # v0.2.12
-
       - name: Create KinD cluster ${{ matrix.version }}
         id: kind
         env:

.github/workflows/pr-validation.yaml

@@ -81,48 +81,18 @@ jobs:
         with:
           go-version-file: "go.mod"
 
-      - name: Run helm-template
-        run: |
-          helm template deploy/helm/grafana-operator/
-
-      - name: Run helm-lint
-        run: |
-          helm lint deploy/helm/grafana-operator/
       - name: Run helm-docs
         run: |
-          make helm/docs
+          make helm-docs
 
       - name: Check if working tree is dirty
         run: |
           if [[ $(git status --porcelain) ]]; then
             git diff
-            echo '::error::run make helm/docs and commit changes'
+            echo '::error::run make helm-docs and commit changes'
             exit 1
           fi
 
-  kustomize:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Clone repo
-        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
-        with:
-          persist-credentials: false
-
-      - name: Setup go
-        uses: actions/setup-go@d35c59abb061a4a6fb18e82ac0862c26744d6ab5 # v5
-        with:
-          go-version-file: "go.mod"
-
-      - name: Install kustomize
-        run: |
-          make kustomize
-
-      - name: Check if overlays can be successfully built
-        run: |
-          for d in deploy/kustomize/overlays/*/ ; do
-            kustomize build "$d" --load-restrictor LoadRestrictionsNone > /dev/null
-          done
-
   trivy:
     runs-on: ubuntu-latest
     steps:

.github/workflows/release.yaml

@@ -73,7 +73,7 @@ jobs:
           app-id: ${{ fromJSON(steps.secrets.outputs.secrets || '{}').APP_ID }}
           private-key: ${{ fromJSON(steps.secrets.outputs.secrets || '{}').APP_PRIVATE_KEY }}
           repositories: helm-charts
-          owner: '${{ github.event.repository.owner.login }}'
+          owner: "${{ github.event.repository.owner.login }}"
 
       - name: Set the correct token (Github App or PAT) # zizmor: ignore[template-injection] app token considered safe
         run: |
@@ -132,11 +132,7 @@ jobs:
           echo "GHCR_REPO=$GHCR_REPO" >> $GITHUB_ENV
       - name: update-kustomize-image
         run: |
-          # Install kustomize
-          make kustomize
-          # Update image to match the new image and tag
-          cd deploy/kustomize/base
-          kustomize edit set image ghcr.io/${{ github.repository }}=${{ env.GHCR_REPO }}:${RELEASE_NAME}
+          make kustomize-set-image
       - name: Login to GitHub Container Registry
         uses: docker/login-action@74a5d142397b4f367a81961eba4e8cd7edddf772 # v3
         with:
@@ -151,14 +147,11 @@ jobs:
             --path="./deploy/kustomize" \
             --source="${PUBLISH_SOURCE}" \
             --revision="${RELEASE_NAME}/${GITHUB_SHA}"
-      - name: update-kustomize-assert
+      - name: upload kustomize assets
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: |
-          for d in deploy/kustomize/overlays/*/ ; do
-            kustomize build "$d" --load-restrictor LoadRestrictionsNone > kustomize-$(basename "$d").yaml
-          done
-          kustomize build config/crd > crds.yaml
+          make kustomize-github-assets
           gh release upload "${RELEASE_NAME}" kustomize-*.yaml crds.yaml
 
   image: