-
Notifications
You must be signed in to change notification settings - Fork 54
Min size autodetect #2325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Min size autodetect #2325
Conversation
Regarding deeply nested field, maybe Another questions is what would be good default values for those resolutions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through it again, and now makes more sense to me: your default value in the code is probably good enough.
A high-level question: this PR looks also partially resolve the short-issue. I guess they will work together?
yeah, it does partially resolve it, but not as robustly as the other one. For example, if structure has rounded corners everywhere this autodetection feature would not see anything. But given that the other approach is more computationally intensive, might still be good to have a rough estimation like this one |
b73cff8
to
cd6bdb1
Compare
2fc76eb
to
b8cd3b1
Compare
b8cd3b1
to
e98ae2e
Compare
e98ae2e
to
86b3f0d
Compare
I am not sure about naming
SmallestFeatureSpec
and also how deep it is tucked away:would appreciate any suggestions