Skip to content

Commit e98ae2e

Browse files
set default concave_resoltion=None, changelog entry
1 parent 364cd7c commit e98ae2e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111
- The method `Geometry.reflected` can be used to create a reflected copy of any geometry off a plane. As for other transformations, for efficiency, `reflected` `PolySlab` directly returns an updated `PolySlab` object rather than a `Transformed` object, except when the normal of the plane of reflection has a non-zero component along the slab axis, in which case `Transformed` is still returned.
1212
- Validation check for unit error in grid spacing.
1313
- Validation that when symmetry is imposed along a given axis, the boundary conditions on each side of the axis are identical.
14+
- Fields `convex_resolution`, `concave_resolution`, and `mixed_resolution` in `CornerFinderSpec` can be used to take into account the dimensions of autodetected convex, concave, or mixed geometric features when `dl_min` is automatically inferred during automatic grid generation.
1415

1516
### Changed
1617
- Supplying autograd-traced values to geometric fields (`center`, `size`) of simulations, monitors, and sources now logs a warning and falls back to the static value instead of erroring.

tidy3d/components/grid/corner_finder.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class CornerFinderSpec(Tidy3dBaseModel):
4545
)
4646

4747
concave_resolution: Optional[pd.PositiveInt] = pd.Field(
48-
2,
48+
None,
4949
title="Concave Region Resolution.",
5050
description="Specifies number of steps to use for determining `dl_min` based on concave featues."
5151
"If set to ``None``, then the corresponding `dl_min` reduction is not applied.",

0 commit comments

Comments
 (0)