feat: expand arrow type conversion test #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipleblanc
approved these changes
May 7, 2025
|
This was a follow-up from the previous change, would you mind taking a quick look at this one? |
Xuanwo
approved these changes
May 10, 2025
There was a problem hiding this comment.
Thank you @jdockerty for working on this. Nice change to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Helps #1277
What changes are included in this PR?
This expands the
test_type_conversiontest with the specificDataType::Dictionarytype.Props to @phillipleblanc for this, as I noticed the extra coverage on his PR which I believe is very useful to capture1.
Footnotes
I was looking to add similar to https://github.com/apache/iceberg-rust/pull/1293, but it was merged just before I pushed the changes 😆 ↩