feat: support arrow dictionary in schema conversion #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
reviewed
May 5, 2025
alamb
approved these changes
May 5, 2025
There was a problem hiding this comment.
This looks great to me -- thank you @jdockerty
(though note I am not an expert in this code nor a committer on the iceberg project)
|
Looks like @phillipleblanc made a similar PR here: #1283 |
|
@liurenjie1024 or @Xuanwo, do you have time to review this PR? |
phillipleblanc
approved these changes
May 6, 2025
liurenjie1024
approved these changes
May 6, 2025
Xuanwo
pushed a commit
that referenced
this pull request
May 10, 2025
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Helps #1277 ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> This expands the `test_type_conversion` test with the specific `DataType::Dictionary` type. Props to @phillipleblanc for this, as I noticed the extra coverage on his PR which I believe is very useful to capture[^1]. [^1]: I was looking to add similar to #1293, but it was merged just before I pushed the changes 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
DataType::Dictionaryfor arrow schema conversion #1277What changes are included in this PR?
An expansion to the current schema conversion for arrow to an iceberg schema.
This uses the suggestion provided by @alamb (here) for the schema conversion work.
Are these changes tested?
The current test for schema conversion has been expanded.
I've also taken the liberty of altering the
assert_eq!call to use thepretty_assertionsversion, as it makes viewing the failure much simpler with a large JSON structure - I can revert this though if it is problematic.