-
Notifications
You must be signed in to change notification settings - Fork 620
Extension for Ansible redirects #2418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Conversation
37aaddd
to
59a6df2
Compare
59a6df2
to
c5ec601
Compare
768cd3f
to
1e48ae3
Compare
1e48ae3
to
5641adf
Compare
5641adf
to
97be9ad
Compare
97be9ad
to
acdbce4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
09a7683
to
910c941
Compare
@webknjaz / @felixfontein / @gotmax23 Could we please get another round of reviews here? I've added all the redirects to the ReadTheDocs project and this PR is one of the last hurdles in the way of the |
efe854f
to
d9ac192
Compare
d9ac192
to
de60b45
Compare
make webdocs ANSIBLE_VERSION="${{ | ||
make webdocs ${{ | ||
inputs.generate-redirects && 'EXTRA_TAGS="-t redirects"' || '' | ||
}} ANSIBLE_VERSION="${{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@webknjaz Hey again, thanks for the previous comment that made me re-think this. What I had here before was garbage. I'm not sure how it got muddled up so my apologies.
When the generate-redirects
input is true, the command is make webdocs EXTRA_TAGS="-t redirects" ANSIBLE_VERSION=""
When generate-redirects
is false, the command is make webdocs ANSIBLE_VERSION=""
. It does look like there's an extra space between webdocs
and ANSIBLE_VERSION
but I don't think that has any effect in how the make command gets evaluated.
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
de60b45
to
333b36b
Compare
Fixes #2147 and supercedes #2266
This PR extends the Sphinx reredirects extension to load redirects for Ansible documentation from a toml file. The purpose is to replace the httpd mod_rewrite rules in https://github.com/ansible/docsite/blob/main/ansible/11/.htaccess and https://github.com/ansible/docsite/blob/main/.htaccess in a way that is compatible with ReadTheDocs.
If this PR is accepted and merged, there are two follow on actions:
robots.txt
file to stop crawlers from indexing the generated HTML files. We can put therobots.txt
file in theansible/docsite
repo and copy it across as part of the ReadTheDocs build.docs/docsite/rst/user_guide
folder.