Skip to content

feat(source-microsoft-lists): fix ListItems and ContentValues #58575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ acceptance_tests:
tests:
- spec_path: "manifest.yaml"
connection:
bypass_reason: "This is a builder contribution, and we do not have secrets at this time"
tests:
- config_path: secrets/config.json
timeout_seconds: 7200
discovery:
bypass_reason: "This is a builder contribution, and we do not have secrets at this time"
basic_read:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
# Copyright (c) 2025 Airbyte, Inc., all rights reserved.

"""Airbyte standard connector tests.
The FAST Airbyte Standard Tests suite is designed to ensure that connectors meet Airbyte
protocol standards.
"""

import pytest

from airbyte_cdk.test import standard_tests


pytest_plugins = ["airbyte_cdk.test.standard_tests.pytest_hooks"]


@pytest.mark.slow
@pytest.mark.requires_creds
class TestAirbyteStandardTests(standard_tests.DeclarativeSourceTestSuite):
"""Test suite for the Airbyte standard tests.
This class inherits from SourceTestSuiteBase and implements all of the tests in the suite.
As long as the class name starts with "Test", pytest will automatically discover and run the
tests in this class.
"""

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
[build-system]
requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
name = "source-microsoft-lists-tests"
version = "0.0.23"
description = "Unit tests for source-microsoft-lists"
authors = ["Airbyte <contact@airbyte.io>"]

[tool.poetry.dependencies]
python = "^3.10,<3.13"
airbyte-cdk = "^6"
pytest = "^8"

[tool.pytest.ini_options]
filterwarnings = [
"ignore:This class is experimental*"
]

Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,9 @@ definitions:
requester:
$ref: "#/definitions/base_requester"
path: >-
/sites/{{ config['site_id'] }}/lists/{{ stream_partition.list
}}/items/{{ stream_partition.item }}
/sites/{{ config['site_id'] }}/lists/{{
stream_partition.item_info.list_id }}/items/{{
stream_partition.item_info.item_id }}
http_method: GET
record_selector:
type: RecordSelector
Expand All @@ -119,15 +120,8 @@ definitions:
- type: SubstreamPartitionRouter
parent_stream_configs:
- type: ParentStreamConfig
parent_key: id
partition_field: list
stream:
$ref: "#/definitions/streams/lists"
- type: SubstreamPartitionRouter
parent_stream_configs:
- type: ParentStreamConfig
parent_key: id
partition_field: item
parent_key: item_info
partition_field: item_info
stream:
$ref: "#/definitions/streams/items"
schema_loader:
Expand Down Expand Up @@ -175,6 +169,15 @@ definitions:
type: InlineSchemaLoader
schema:
$ref: "#/schemas/items"
transformations:
- type: AddFields
fields:
- type: AddedFieldDefinition
path:
- item_info
value: >-
{{ { "list_id": stream_partition.list, "item_id": record.id }
}}
columnvalues:
type: DeclarativeStream
name: columnvalues
Expand All @@ -185,8 +188,9 @@ definitions:
requester:
$ref: "#/definitions/base_requester"
path: >-
/sites/{{ config['site_id'] }}/lists/{{ stream_partition.list
}}/items/{{ stream_partition.item}}
/sites/{{ config['site_id'] }}/lists/{{
stream_partition.item_info.list_id }}/items/{{
stream_partition.item_info.item_id }}
http_method: GET
request_parameters:
expand: fields
Expand All @@ -211,15 +215,8 @@ definitions:
- type: SubstreamPartitionRouter
parent_stream_configs:
- type: ParentStreamConfig
parent_key: id
partition_field: list
stream:
$ref: "#/definitions/streams/lists"
- type: SubstreamPartitionRouter
parent_stream_configs:
- type: ParentStreamConfig
parent_key: id
partition_field: item
parent_key: item_info
partition_field: item_info
stream:
$ref: "#/definitions/streams/items"
schema_loader:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 18ea5fae-f0b1-4d82-9aef-832bb922a5b5
dockerImageTag: 0.0.23
dockerImageTag: 0.0.24
dockerRepository: airbyte/source-microsoft-lists
githubIssueLabel: source-microsoft-lists
icon: icon.svg
Expand All @@ -26,6 +26,15 @@ data:
releaseDate: 2024-10-18
releaseStage: alpha
supportLevel: community
connectorTestSuitesOptions:
# no-op for now but will get enabled when the capability is added to airbyte-ci
- suite: integrationTests
testSecrets:
- name: SECRET_SOURCE-MICROSOFT-LISTS_CREDS
fileName: config.json
secretStore:
type: GSM
alias: airbyte-connector-testing-secret-store
documentationUrl: https://docs.airbyte.com/integrations/sources/microsoft-lists
tags:
- language:manifest-only
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/microsoft-lists.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ Microsoft Lists connector enables seamless data integration and synchronization

| Version | Date | Pull Request | Subject |
|------------------|-------------------|--------------|----------------|
| 0.0.24 | 2025-04-30 | [58575](https://github.com/airbytehq/airbyte/pull/58575) | Fix ListItems and ColumnValues streams |
| 0.0.23 | 2025-04-19 | [58521](https://github.com/airbytehq/airbyte/pull/58521) | Update dependencies |
| 0.0.22 | 2025-04-12 | [57861](https://github.com/airbytehq/airbyte/pull/57861) | Update dependencies |
| 0.0.21 | 2025-04-05 | [57042](https://github.com/airbytehq/airbyte/pull/57042) | Update dependencies |
Expand Down
Loading