feat(source-microsoft-lists): fix ListItems and ContentValues #58575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aaronsteers
reviewed
Apr 25, 2025
aaronsteers
requested changes
Apr 25, 2025
There was a problem hiding this comment.
This looks great, @aldogonzalez8 ! One change requested. After this, I hope to see the FAST tests running under the "Unit tests" category of the airbyte-ci report.
aaronsteers
reviewed
Apr 25, 2025
Comment on lines
30
to
36
| - suite: unitTests | ||
| testSecrets: | ||
| - name: SECRET_SOURCE-MICROSOFT-LISTS_CREDS | ||
| fileName: config.json | ||
| secretStore: | ||
| type: GSM | ||
| alias: airbyte-connector-testing-secret-store |
There was a problem hiding this comment.
Shared in DM but posting here for posterity...
Apparently unitTests don't support secrets. And manifest-only connectors don't support integration tests...
Suggestion is to move these into integration tests and add that capability (integration tests for manifest-only connectors) into airbyte-ci in a future iteration.
aaronsteers
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Looks great, @aldogonzalez8! Thanks for your help in testing the new tests!
ericvanbenschoten-dv01
pushed a commit
to ericvanbenschoten-dv01/airbyte_ev
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the ListItem and ContentValues streams that have errors when attempting to fetch certain records.
How
They were doing a Cartesian product "Lists" X "Items", no matter if the
itemdidn't belong to theList, which was leading to errors like:We are also adding FAST aribyte standard tests.
Review guide
User Impact
Users can nos sync these streams without errors
Can this PR be safely reverted and rolled back?