Fix compatibility with zwave-js-server version 3.0.0 and above. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a version compatibility is now only checked on server side. Remove some compilation warnings.
|
Thanks @spudwebb, I have been meaning to switch this check over to the But I agree, not sure if its worth to keep this going. |
|
HI @spudwebb & @pnpebeling Just note: this is still on my radar. So once back in the UK (first week of June), will look to get this all merged and into the V4 code base. |
|
Great, will you also release v4 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zwave-js-server version number no longer match the supported schema version, so I removed the checks on the zwave-js-server version. The schema version compatibility is now only checked on server side when the
set_api_schemacommand is sent.I also removed some compilation warnings.