Skip to content

BUG: fix casting to a GeoSeries in to_geodataframe under new xarray #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2025
Merged

BUG: fix casting to a GeoSeries in to_geodataframe under new xarray #112

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83addc4
(fix): don't cast to geopandas series if not needed
ilan-gold May 1, 2025
86949f3
(chore): lint
ilan-gold May 1, 2025
8caa6a1
(fix): correct message
ilan-gold May 1, 2025
0041326
ensure we always get a GeoSeries
martinfleis May 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions xvec/accessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,11 +960,16 @@ def to_geodataframe(
if geometry is None:
geometry = df.index.name
df = df.reset_index()

# ensure CRS of all columns is preserved
for c in df.columns:
if c in self._geom_coords_all:
df[c] = gpd.GeoSeries(df[c], crs=self._obj[c].attrs.get("crs", None))
# there is a geopandas bug that does not allow upcasting a series
# with a geometry dtype directly
df[c] = gpd.GeoSeries(
df[c].values,
crs=self._obj[c].attrs.get("crs", None),
index=df[c].index,
)

if geometry is not None:
if geometry not in self._geom_coords_all: # variable geometry
Expand Down