Skip to content

UP my solution #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions numpy_questions.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,21 @@ def max_index(X):
Returns
-------
(i, j) : tuple(int)
The row and columnd index of the maximum.
The row and column index of the maximum.

Raises
------
ValueError
If the input is not a numpy array or
if the shape is not 2D.
"""
i = 0
j = 0
if not isinstance(X, np.ndarray):
raise ValueError("Input must be a numpy array.")

# TODO

return i, j
if X.ndim != 2:
raise ValueError("Input array must be 2D.")
max_idx = np.unravel_index(np.argmax(X), X.shape)
return max_idx


def wallis_product(n_terms):
Expand All @@ -62,6 +63,13 @@ def wallis_product(n_terms):
pi : float
The approximation of order `n_terms` of pi using the Wallis product.
"""
# XXX : The n_terms is an int that corresponds to the number of
# terms in the product. For example 10000.
return 0.
if n_terms < 0:
raise ValueError("Number of terms must be non-negative.")
product = 1.0
for n in range(1, n_terms + 1):
numerator = 4 * n**2
denominator = (4 * n**2) - 1
product *= numerator / denominator

pi = product * 2
return pi
Loading