Skip to content

UP my solution #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions numpy_questions.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
errors by calling `flake8` at the root of the repo.
"""
import numpy as np
import math


def max_index(X):
Expand All @@ -37,10 +38,21 @@ def max_index(X):
If the input is not a numpy array or
if the shape is not 2D.
"""
if not isinstance(X, np.ndarray):
raise ValueError("Input must be a numpy array.")
if X.ndim != 2:
raise ValueError("Input array must be 2D.")

i = 0
j = 0
max = -math.inf

# TODO
for row in range(X.shape[0]):
for column in range(X.shape[1]):
if X[row][column] > max:
i = row
j = column
max = X[row][column]

return i, j

Expand All @@ -62,6 +74,12 @@ def wallis_product(n_terms):
pi : float
The approximation of order `n_terms` of pi using the Wallis product.
"""
# XXX : The n_terms is an int that corresponds to the number of
# terms in the product. For example 10000.
return 0.
if n_terms == 0:
return 2.0 # Base case: Approximation of pi with no terms

product = 1.0
for n in range(1, n_terms + 1):
term = (4 * n ** 2) / ((4 * n ** 2) - 1)
product *= term

return 2 * product
Loading