-
Notifications
You must be signed in to change notification settings - Fork 213
Show recurring icon in payment methods #4299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really close, but I think we have a few small visual aspects to polish.
.components-popover__content { | ||
border-radius: 4px; | ||
box-shadow: 0px 2px 6px 0px rgba( 0, 0, 0, 0.05 ); | ||
padding: 5px 10px; | ||
background-color: #000000; | ||
color: #ffffff; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on confirmation from design about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the confirmation from design, we are keeping these different as one if a tooltip and another is a popover. However, in the previous implementation, I was using the popover component for showing Supports recurring payments
message. I have updated the component in facce12
Thanks @daledupreez, for the feedback. I have made some adjustments in my recent commits and it's ready for review again. 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this is working well, but I think we can remove the one cursor
CSS rule that came up.
const Icon = styled.img` | ||
height: 14px; | ||
width: 14px; | ||
cursor: pointer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this? I am not sure that the item is clickable, so adding a pointer cursor doesn't feel right. Also, it doesn't seem to be visible for me! 🙃
Fixes STRIPE-192
Fixes #2831
Changes proposed in this Pull Request:
Testing instructions