If the relay parameter is not set, the empty? errors out. #449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towo
approved these changes
Apr 24, 2025
|
Description could've used a bit more love. :) |
Sorry, thought I had put in a better description. No idea where I pasted that 8-) |
smortex
requested changes
May 6, 2025
| @@ -232,7 +232,7 @@ def create | |||
|
|
|||
| case resource[:backend].to_s | |||
| when 'relay' | |||
| t << "olcRelay: #{resource[:relay]}\n" unless resource[:relay].empty? | |||
| t << "olcRelay: #{resource[:relay]}\n" if resource[:relay] | |||
There was a problem hiding this comment.
An empty string/array now evaluates to a truthy value, so this will change the code behavior.
If we can also pass undef it may make sense to check resource[:relay].nil? and resource[:relay].empty?:
Suggested change
| t << "olcRelay: #{resource[:relay]}\n" if resource[:relay] | |
| t << "olcRelay: #{resource[:relay]}\n" unless resource[:relay].nil? || resource[:relay].empty? |
You can describe the wrong behavior you fix in the PR first message. It will be linked to in the generated ChangeLog with the next release of the module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues