feat: Allow db.Key in the index-method
#1445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phorward
requested changes
Mar 25, 2025
There was a problem hiding this comment.
Hi @ArneGudermann, this is a breaking change, as the index-function now behaves differently than before. Anyway, as the SEO-stuff is being reworked, we can do it so. You should handle the commented stuff. I would like to discuss this in a viur-meeting.
src/viur/core/prototypes/list.py
Outdated
| skel = self.viewSkel( | ||
| allow_client_defined=utils.string.is_prefix(self.render.kind, "json"), | ||
| _excludeFromAccessLog=True, | ||
| ) | ||
| if isinstance(key, db.Key): | ||
| assert key.kind == self.kindName | ||
| skel.read(key) |
There was a problem hiding this comment.
This will render an empty skeleton when the key is not found.
src/viur/core/prototypes/list.py
Outdated
| skel = self.viewSkel( | ||
| allow_client_defined=utils.string.is_prefix(self.render.kind, "json"), | ||
| _excludeFromAccessLog=True, | ||
| ) | ||
| if isinstance(key, db.Key): | ||
| assert key.kind == self.kindName |
There was a problem hiding this comment.
This will raise an error 500. I would like to use this as part of the previous condition.
phorward
changed the title
db.Key in the index methodedb.Key in the index-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this now you can call the index Methode direct with a db.Key like:
/foo/agNmb29yCQsSA2Jhchh7DAinstead of
/foo/view/agNmb29yCQsSA2Jhchh7DASecond if you have a Method like:
def index(self, key: db.Key | str | None = None)the
keyis now parsed to adb.Keyif this is possible.