[LibArchFPGA] Added Library Model IDs as constexpr #3022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created static constexpr references to the library model IDs (such as input, output, names, and latch). It is very common to reference these models during execution of VPR. Often we would search for these models in the LogicalModels structure; however, these model IDs will always be the same. By storing static references to these IDs, the compiler can easily optimize parts of the code which need to check if a model ID is an input/output for example.
github-actions
bot
added
VPR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created static constexpr references to the library model IDs (such as input, output, names, and latch). It is very common to reference these models during execution of VPR. Often we would search for these models in the LogicalModels structure; however, these model IDs will always be the same.
By storing static references to these IDs, the compiler can easily optimize parts of the code which need to check if a model ID is an input/output for example.