Skip to content

Fixes #38435 - remove select2 tooltips #10546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

MariaAga
Copy link
Member

Removed the work arounds to try to make the tooltips works
removed all tooltips
sometimes they are re-added when a select happens (sometimes because a new part of the page is added), so also remove them on select.
It breaks tests randomly with no way to fix them otherwise

@github-actions github-actions bot added the Legacy JS PRs making changes in the legacy Javascript stack label May 21, 2025
@ekohl
Copy link
Member

ekohl commented May 21, 2025

Is there a way we could drop the select2 dependency altogether? Any idea how many select2 tooltips we have in our codebase(s)?

@MariaAga
Copy link
Member Author

I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult.
the tooltips are added by select2 to the clear button, and to the select2 result bar/span

@MariaAga
Copy link
Member Author

image

@ekohl
Copy link
Member

ekohl commented May 21, 2025

I dont see how, as just updating it was such a pain, replacing it and keeping the functionality in all different uses and plugins will be very difficult.

I see it is indeed used widely. I'd like to hear your thoughts on how to remove it. Do we have a replacement? If so, can we at least deprecate it for us developers?

@MariaAga
Copy link
Member Author

how to remove it - probably by replacing all .html.erb to react, otherwise were working hard on a code that we will delete later anyway

@ekohl
Copy link
Member

ekohl commented May 21, 2025

I fear you're right.

@nadjaheitmann
Copy link
Contributor

I had the integration test in foreman_puppet running against this PR as this is where it popped up and now it works just fine 👍

@nadjaheitmann
Copy link
Contributor

Is there anything preventing this one from being merged? Would love to have the foreman_puppet CI to be green again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy JS PRs making changes in the legacy Javascript stack Not yet reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants