Skip to content

feat: use existing cloud logs instance #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: use existing cloud logs instance #610

wants to merge 7 commits into from

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Nov 28, 2024

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Nov 28, 2024
@jor2 jor2 marked this pull request as ready for review December 3, 2024 10:46
@jor2 jor2 requested review from iamar7 and shemau as code owners December 3, 2024 10:46
@jor2
Copy link
Member Author

jor2 commented Dec 3, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Dec 3, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Dec 12, 2024

/run pipeline

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes looks good. Shouldn't we test the existing_cl_instance feature in any test?

@ocofaigh
Copy link
Member

Agree - lets ensure we have test coverage for this

@jor2
Copy link
Member Author

jor2 commented Feb 13, 2025

need to update test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants