Skip to content

fix: use defaultValue only if value is undefined #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

ddubrava
Copy link
Contributor

Added explicit validation for undefined, so falsy values (0, false, '', etc.) are not replaced by a default value

See #612

Copy link

changeset-bot bot commented Mar 26, 2025

🦋 Changeset detected

Latest commit: 0146672

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
example Patch
@ladle/react Patch
test-addons Patch
test-babel Patch
test-config Patch
test-config-ts Patch
test-css Patch
test-decorators Patch
test-playwright Patch
test-programmatic Patch
test-provider Patch
test-baseweb Patch
test-msw Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ddubrava ddubrava changed the title Use defaultValue only if value is undefined fix: use defaultValue only if value is undefined Mar 26, 2025
Copy link
Collaborator

@alxmyth alxmyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch!

@tajo tajo merged commit 4983e14 into tajo:main May 2, 2025
2 checks passed
@tajo tajo mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants