-
Notifications
You must be signed in to change notification settings - Fork 58
Add navigator-title slot to NavigatorCard + fix small UI spacing details #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3aa12ff
e29fa0f
0c3853c
f1e3b9b
a228635
56a6099
a658773
f779c80
9634f41
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -13,7 +13,7 @@ | |||
:class="{ expanded, active: isActive, 'is-group': isGroupMarker }" | ||||
:style="{ '--nesting-index': item.depth }" | ||||
:data-nesting-index="item.depth" | ||||
:id="`container-${item.uid}`" | ||||
:id="item.uid ? `container-${item.uid}` : null" | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should keep the |
||||
:aria-hidden="isRendered ? null : 'true'" | ||||
:hideNavigatorIcon="isGroupMarker" | ||||
@keydown.left.native.prevent="handleLeftKeydown" | ||||
|
@@ -75,7 +75,7 @@ | |||
} | ||||
) }}</span> | ||||
<span | ||||
v-if="!isParent" | ||||
v-else-if="item.siblingsCount" | ||||
:id="siblingsLabel" | ||||
hidden | ||||
> | ||||
|
@@ -184,6 +184,10 @@ export default { | |||
type: Object, | ||||
default: () => ({}), | ||||
}, | ||||
customTag: { | ||||
type: String, | ||||
require: false, | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Or |
||||
}, | ||||
}, | ||||
idState() { | ||||
return { | ||||
|
@@ -193,7 +197,7 @@ export default { | |||
}, | ||||
computed: { | ||||
isGroupMarker: ({ item: { type } }) => type === TopicTypes.groupMarker, | ||||
isParent: ({ item, isGroupMarker }) => !!item.childUIDs.length && !isGroupMarker, | ||||
isParent: ({ item, isGroupMarker }) => !!item.childUIDs?.length && !isGroupMarker, | ||||
parentLabel: ({ item }) => `label-parent-${item.uid}`, | ||||
siblingsLabel: ({ item }) => `label-${item.uid}`, | ||||
usageLabel: ({ item }) => `usage-${item.uid}`, | ||||
|
@@ -204,7 +208,11 @@ export default { | |||
), | ||||
isBeta: ({ item: { beta } }) => !!beta, | ||||
isDeprecated: ({ item: { deprecated } }) => !!deprecated, | ||||
refComponent: ({ isGroupMarker }) => (isGroupMarker ? 'h3' : Reference), | ||||
refComponent: ({ isGroupMarker, customTag }) => { | ||||
if (customTag) return customTag; | ||||
if (isGroupMarker) return 'h3'; | ||||
return Reference; | ||||
}, | ||||
}, | ||||
methods: { | ||||
toggleTree() { | ||||
|
Uh oh!
There was an error while loading. Please reload this page.