Skip to content

fix: redirect trailing slash normalization relatively instead of against root #13719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HoldYourWaffle
Copy link
Contributor

Fixes #13718.
As mentioned there: Location is allowed to be relative, so I just... did that.
For the scenario listed in the issue that means /sveltekit/sverdle/ is redirected with Location: ../sverdle, which correctly resolves to /sveltekit/sverdle.

Remaining things to consider

  • 1. Still need to inline the get-relative-path code that does the heavy lifting, but I'd like to confirm this is the correct solution first.
  • 2. What should tests for this look like? Should I create a whole adapter-node+dynamic base project or keep it simple and just check if the path is relative?
  • 3. adapter-node currently imports the internal relative_pathname utility through @sveltejs/kit/node, which feels a bit weird, is there a better place for this?
  • 4. I'm not 100% confident this doesn't regress #2515, unfortunately there's no minimal reproduction and #4414 didn't add a test. I tried various combinations of slashes and protocol-ish paths, but even taking out #4414's fix I always got 404 rather than redirected. Is this perhaps taken care of elsewhere now? Perhaps @wbster or @benmccann can clarify.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: 2f84edc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/adapter-node Patch
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trailing slash normalization always redirects against root
1 participant