Skip to content

Run tests on 3.14 #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Run tests on 3.14 #3828

wants to merge 2 commits into from

Conversation

patrick91
Copy link
Member

@patrick91 patrick91 commented Apr 1, 2025

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Summary by Sourcery

Add support for Python 3.14 in test matrix and noxfile configuration

CI:

  • Update GitHub Actions workflow to include Python 3.14-dev test session

Tests:

  • Extend Python version support to include Python 3.14 in test configurations

Copy link
Contributor

sourcery-ai bot commented Apr 1, 2025

Reviewer's Guide by Sourcery

This pull request modifies the test suite to include Python 3.14. It updates the noxfile.py to include 3.14 in the list of Python versions and adds 3.14-dev to the test matrix in .github/workflows/test.yml.

Updated class diagram for noxfile.py

classDiagram
    class noxfile.py {
      -PYTHON_VERSIONS: List[str]
    }
    note for noxfile.py "Updated PYTHON_VERSIONS to include Python 3.14"
Loading

File-Level Changes

Change Details Files
The pull request updates the Python versions used for testing to include 3.14.
  • Added '3.14' to the list of Python versions in noxfile.py.
  • Added '3.14-dev' to the test matrix in .github/workflows/test.yml.
noxfile.py
.github/workflows/test.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (50a8347) to head (9fc011d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3828   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         508      508           
  Lines       32961    32961           
  Branches     1712     1712           
=======================================
  Hits        31327    31327           
  Misses       1358     1358           
  Partials      276      276           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

codspeed-hq bot commented Apr 1, 2025

CodSpeed Performance Report

Merging #3828 will not alter performance

Comparing feature/314 (9fc011d) with main (50a8347)

Summary

✅ 21 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant