-
Notifications
You must be signed in to change notification settings - Fork 873
feat(mysql): :copyfrom support via LOAD DATA INFILE #2545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
{{define "copyfromCodeGoSqlDriver"}} | ||
{{range .GoQueries}} | ||
{{if eq .Cmd ":copyfrom" }} | ||
var readerHandlerSequenceFor{{.MethodName}} uint32 = 1 | ||
|
||
func convertRowsFor{{.MethodName}}(w *io.PipeWriter, {{.Arg.SlicePair}}) { | ||
e := mysqltsv.NewEncoder(w, {{ len .Arg.Fields }}, nil) | ||
for _, row := range {{.Arg.Name}} { | ||
{{- with $arg := .Arg }} | ||
{{- range $arg.Fields}} | ||
{{- if eq .Type "string"}} | ||
e.AppendString({{if eq (len $arg.Fields) 1}}row{{else}}row.{{.Name}}{{end}}) | ||
{{- else if eq .Type "[]byte"}} | ||
e.AppendBytes({{if eq (len $arg.Fields) 1}}row{{else}}row.{{.Name}}{{end}}) | ||
{{- else}} | ||
e.AppendValue({{if eq (len $arg.Fields) 1}}row{{else}}row.{{.Name}}{{end}}) | ||
{{- end}} | ||
{{- end}} | ||
{{- end}} | ||
} | ||
w.CloseWithError(e.Close()) | ||
} | ||
|
||
{{range .Comments}}//{{.}} | ||
{{end -}} | ||
// {{.MethodName}} uses MySQL's LOAD DATA LOCAL INFILE and is not atomic. | ||
// | ||
// Errors and duplicate keys are treated as warnings and insertion will | ||
// continue, even without an error for some cases. Use this in a transaction | ||
// and use SHOW WARNINGS to check for any problems and roll back if you want to. | ||
// | ||
// Check the documentation for more information: | ||
// https://dev.mysql.com/doc/refman/8.0/en/load-data.html#load-data-error-handling | ||
func (q *Queries) {{.MethodName}}(ctx context.Context{{if $.EmitMethodsWithDBArgument}}, db DBTX{{end}}, {{.Arg.SlicePair}}) (int64, error) { | ||
pr, pw := io.Pipe() | ||
defer pr.Close() | ||
rh := fmt.Sprintf("{{.MethodName}}_%d", atomic.AddUint32(&readerHandlerSequenceFor{{.MethodName}}, 1)) | ||
mysql.RegisterReaderHandler(rh, func() io.Reader { return pr }) | ||
defer mysql.DeregisterReaderHandler(rh) | ||
go convertRowsFor{{.MethodName}}(pw, {{.Arg.Name}}) | ||
// The string interpolation is necessary because LOAD DATA INFILE requires | ||
// the file name to be given as a literal string. | ||
result, err := {{if (not $.EmitMethodsWithDBArgument)}}q.{{end}}db.ExecContext(ctx, fmt.Sprintf("LOAD DATA LOCAL INFILE '%s' INTO TABLE {{.TableIdentifierForMySQL}} %s ({{range $index, $name := .Arg.ColumnNames}}{{if gt $index 0}}, {{end}}{{$name}}{{end}})", "Reader::" + rh, mysqltsv.Escaping)) | ||
if err != nil { | ||
return 0, err | ||
} | ||
return result.RowsAffected() | ||
} | ||
|
||
{{end}} | ||
{{end}} | ||
{{end}} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
CREATE TABLE foo (a text, b integer, c DATETIME, d DATE); | ||
|
||
-- name: InsertValues :copyfrom | ||
INSERT INTO foo (a, b, c, d) VALUES (?, ?, ?, ?); | ||
|
||
-- name: InsertSingleValue :copyfrom | ||
INSERT INTO foo (a) VALUES (?); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a gross hack, but I don't want to change how parseDriver works right now.