Skip to content

Add TOC object entry support for C domain #13497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

Cynerd
Copy link
Contributor

@Cynerd Cynerd commented Apr 23, 2025

Purpose

This is based on the C++ implementation.

References

@Cynerd Cynerd force-pushed the c-domain-entries branch from 1f2b8ae to fdc0e14 Compare April 29, 2025 06:24
@Cynerd
Copy link
Contributor Author

Cynerd commented Apr 29, 2025

The CI is failing in the same way on Master as well as in this PR, thus I think that my changes introduce regression.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests and a CHANGES entry.

A

@Cynerd Cynerd force-pushed the c-domain-entries branch from b0a0e6f to 1e41b56 Compare May 13, 2025 13:40
@Cynerd
Copy link
Contributor Author

Cynerd commented May 13, 2025

Please add tests and a CHANGES entry.

A

I have added a mention to CHANGES, but can you please point me to tests that deal with TOC entries for other domains? I based this change on CPP implementation, thus I tried to look for CPP tests as well, but I couldn't figure out where this is tested. @AA-Turner ?

@AA-Turner AA-Turner merged commit c4d3705 into sphinx-doc:master May 16, 2025
23 of 24 checks passed
@AA-Turner
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants