Skip to content

Example 3 Patch #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Example 3 Patch #3

wants to merge 3 commits into from
+28 −47

Conversation

xp-dv
Copy link

@xp-dv xp-dv commented Sep 27, 2024

Example 3 Patch:

  • Removed unneeded I2C address check
  • Fixed distance calculation
  • Fixed incorrect delay causing sensor to read 0 and delays verified using Siglent SDS2104X Plus oscilloscope
  • Added clarifying comments
  • Tested for function using recently purchased SEN-24805 on the Arduino Nano

@xp-dv
Example 3 Patch: removed unneeded I2C check, fixed distance calculati…
7fcdbd2 
…on, fixed incorrect delay causing sensor to not read, added clarifying comments, tested for function
@xp-dv
Copy link
Author

xp-dv commented Sep 28, 2024

I can also add the oscilloscope capture png to the project folder in a second commit, if that would be helpful for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@xp-dv