-
Notifications
You must be signed in to change notification settings - Fork 680
[ENH] EXPERIMENTAL: TFT model based on the new data pipeline #1812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
=======================================
Coverage ? 86.27%
=======================================
Files ? 53
Lines ? 5838
Branches ? 0
=======================================
Hits ? 5037
Misses ? 801
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi @fkiraly, a doubt related to github: as my base of this stack is merged, will deleting that branch will cause problems with this branch as well? I dont think so, but still want to confirm |
No, the commits are still there on this branch. You just need to merge |
See here the developer guide for chains/stacks of PR: https://www.sktime.net/en/latest/developer_guide/git_workflow.html#working-on-a-chain-of-dependent-tasks |
... it does not say what to do when you merge though. Should we add a minimal update that explains it in a subsection? Just merge A to |
Yes maybe this will help some confused souls like mine :) |
But you did everything right |
Description
This PR implements the tft model based on the new data pipeline. This PR is branched off from #1811