Skip to content

[ENH] EXPERIMENTAL: TFT model based on the new data pipeline #1812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

phoeenniixx
Copy link
Contributor

Description

This PR implements the tft model based on the new data pipeline. This PR is branched off from #1811

@phoeenniixx phoeenniixx changed the title Refactor model [ENH] EXPERIMENTAL: TFT model based on the new data pipeline Apr 6, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

Attention: Patch coverage is 69.41176% with 52 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@bfbe6b2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rch_forecasting/models/base/base_model_refactor.py 32.87% 49 Missing ⚠️
...els/temporal_fusion_transformer/tft_version_two.py 96.90% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1812   +/-   ##
=======================================
  Coverage        ?   86.27%           
=======================================
  Files           ?       53           
  Lines           ?     5838           
  Branches        ?        0           
=======================================
  Hits            ?     5037           
  Misses          ?      801           
  Partials        ?        0           
Flag Coverage Δ
cpu 86.27% <69.41%> (?)
pytest 86.27% <69.41%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phoeenniixx
Copy link
Contributor Author

Hi @fkiraly, a doubt related to github: as my base of this stack is merged, will deleting that branch will cause problems with this branch as well? I dont think so, but still want to confirm

@fkiraly
Copy link
Collaborator

fkiraly commented May 13, 2025

will deleting that branch will cause problems with this branch as well? I dont think so, but still want to confirm

No, the commits are still there on this branch. You just need to merge main into this branch asap, to avoid future issues with the merge to main, of this branch (I see you have already done this so all is fine!)

@fkiraly
Copy link
Collaborator

fkiraly commented May 13, 2025

See here the developer guide for chains/stacks of PR: https://www.sktime.net/en/latest/developer_guide/git_workflow.html#working-on-a-chain-of-dependent-tasks

@fkiraly
Copy link
Collaborator

fkiraly commented May 13, 2025

... it does not say what to do when you merge though. Should we add a minimal update that explains it in a subsection? Just merge A to main, and then merge main into B and propagate through the chain.

@phoeenniixx
Copy link
Contributor Author

... it does not say what to do when you merge though. Should we add a minimal update that explains it in a subsection? Just merge A to main, and then merge main into B and propagate through the chain.

Yes maybe this will help some confused souls like mine :)

@fkiraly
Copy link
Collaborator

fkiraly commented May 13, 2025

Yes maybe this will help some confused souls like mine :)

But you did everything right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PR under review
Development

Successfully merging this pull request may close these issues.

2 participants