Skip to content

Upgrade h5wasm-plugins to support JPEG decompression #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −28
Draft

Upgrade h5wasm-plugins to support JPEG decompression #1796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/demo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"@h5web/h5wasm": "workspace:*",
"axios": "1.8.4",
"axios-hooks": "5.1.1",
"h5wasm-plugins": "0.0.3",
"h5wasm-plugins": "0.1.0",
"normalize.css": "8.0.1",
"react": "18.3.1",
"react-dom": "18.3.1",
Expand Down
4 changes: 2 additions & 2 deletions apps/demo/src/h5wasm/plugin-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ import blosc from 'h5wasm-plugins/plugins/libH5Zblosc.so';
import blosc2 from 'h5wasm-plugins/plugins/libH5Zblosc2.so';
import bshuf from 'h5wasm-plugins/plugins/libH5Zbshuf.so';
import bz2 from 'h5wasm-plugins/plugins/libH5Zbz2.so';
import jpeg from 'h5wasm-plugins/plugins/libH5Zjpeg.so';
import lz4 from 'h5wasm-plugins/plugins/libH5Zlz4.so';
import lzf from 'h5wasm-plugins/plugins/libH5Zlzf.so';
import szf from 'h5wasm-plugins/plugins/libH5Zszf.so';
import zfp from 'h5wasm-plugins/plugins/libH5Zzfp.so';
import zstd from 'h5wasm-plugins/plugins/libH5Zzstd.so';

Expand All @@ -16,9 +16,9 @@ const PLUGINS: Record<Plugin, string> = {
[Plugin.Blosc2]: blosc2,
[Plugin.Bitshuffle]: bshuf,
[Plugin.BZIP2]: bz2,
[Plugin.JPEG]: jpeg,
[Plugin.LZ4]: lz4,
[Plugin.LZF]: lzf,
[Plugin.SZ]: szf,
[Plugin.ZFP]: zfp,
[Plugin.Zstandard]: zstd,
};
Expand Down
4 changes: 2 additions & 2 deletions packages/h5wasm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,8 @@ return:

`@h5web/h5wasm` is capable of identifying and requesting the plugins supported
by the
[`h5wasm-plugins@0.0.1`](https://github.com/h5wasm/h5wasm-plugins/tree/v0.0.1)
package: `blosc`, `bz2`, `lz4`, `lzf`, `szf`, `zfp`, `zstd`.
[`h5wasm-plugins@0.1.0`](https://github.com/h5wasm/h5wasm-plugins/tree/v0.1.0)
package: `blosc`, `blosc2`, `bshuf`, `bz2`, `jpeg`, `lz4`, `lzf`, `zfp`, `zstd`.

A typical implementation of `getPlugin` in a bundled front-end application might
look like this:
Expand Down
6 changes: 5 additions & 1 deletion packages/h5wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,21 @@
},
"peerDependencies": {
"@h5web/app": "workspace:*",
"h5wasm-plugins": "0.1.0",
"react": ">=18",
"typescript": ">=4.5"
},
"peerDependenciesMeta": {
"h5wasm-plugins": {
"optional": true
},
"typescript": {
"optional": true
}
},
"dependencies": {
"comlink": "4.4.2",
"h5wasm": "0.7.9",
"h5wasm": "0.8.1",
"nanoid": "5.1.5"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/h5wasm/src/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export enum Plugin {
Blosc = 'blosc',
Blosc2 = 'blosc2',
BZIP2 = 'bz2',
JPEG = 'jpeg',
LZ4 = 'lz4',
LZF = 'lzf',
SZ = 'szf',
ZFP = 'zfp',
Zstandard = 'zstd',
}
2 changes: 1 addition & 1 deletion packages/h5wasm/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const PLUGINS_BY_FILTER_ID: Record<number, Plugin> = {
32_008: Plugin.Bitshuffle,
32_013: Plugin.ZFP,
32_015: Plugin.Zstandard,
32_017: Plugin.SZ,
32_019: Plugin.JPEG,
32_026: Plugin.Blosc2,
};

Expand Down
27 changes: 11 additions & 16 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@
"noImplicitOverride": true,
"noImplicitReturns": true,
"noFallthroughCasesInSwitch": true,
"noUncheckedSideEffectImports": true,
"forceConsistentCasingInFileNames": true,
"useDefineForClassFields": true,
"useUnknownInCatchVariables": true
"noUncheckedSideEffectImports": true
},
"include": ["*"]
}