Skip to content

Add support for GitHub repository/organization secrets #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AUTHORS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -223,4 +223,6 @@ Contributors

- Chris R (@offbyone)

- Chris Cotter (@ccotter)
- Thomas Buchner (@MrBatschner)

- Chris Cotter (@ccotter)
18 changes: 18 additions & 0 deletions src/github3/actions/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
"""
github3.actions
=============

Module which contains all GitHub Actions related material (only secrets
so far).

See also: http://developer.github.com/v3/actions/
"""
from .secrets import OrganizationSecret
from .secrets import RepositorySecret
from .secrets import SharedOrganizationSecret

__all__ = (
"OrganizationSecret",
"RepositorySecret",
"SharedOrganizationSecret",
)
227 changes: 227 additions & 0 deletions src/github3/actions/secrets.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,227 @@
"""This module contains all the classes relating to GitHub Actions secrets."""
import typing

from .. import models


class PublicKey(models.GitHubCore):

"""Object representing a Public Key for GitHub Actions secrets.

See https://docs.github.com/en/rest/actions/secrets for more details.

.. attribute:: key_id

The ID of the public key

.. attribute:: key

The actual public key as a string
"""

def _update_attributes(self, publickey):
self.key_id = publickey["key_id"]
self.key = publickey["key"]

def _repr(self):
return f"<PublicKey [{self.key_id}]>"

def __str__(self):
return self.key


class _Secret(models.GitHubCore):

"""Base class for all secrets for GitHub Actions.

See https://docs.github.com/en/rest/actions/secrets for more details.
GitHub never reveals the secret value through its API, it is only accessible
from within actions. Therefore, this object represents the secret's metadata
but not its actual value.
"""

class_name = "_Secret"

def _repr(self):
return f"<{self.class_name} [{self.name}]>"

def __str__(self):
return self.name

def _update_attributes(self, secret):
self.name = secret["name"]
self.created_at = self._strptime(secret["created_at"])
self.updated_at = self._strptime(secret["updated_at"])


class RepositorySecret(_Secret):
"""An object representing a repository secret for GitHub Actions.

See https://docs.github.com/en/rest/actions/secrets for more details.
GitHub never reveals the secret value through its API, it is only accessible
from within actions. Therefore, this object represents the secret's metadata
but not its actual value.

.. attribute:: name

The name of the secret

.. attribute:: created_at

The timestamp of when the secret was created

.. attribute:: updated_at

The timestamp of when the secret was last updated
"""

class_name = "RepositorySecret"


class SharedOrganizationSecret(_Secret):
"""An object representing an organization secret for GitHub Actions that is
shared with the repository.

See https://docs.github.com/en/rest/actions/secrets for more details.
GitHub never reveals the secret value through its API, it is only accessible
from within actions. Therefore, this object represents the secret's metadata
but not its actual value.

.. attribute:: name

The name of the secret

.. attribute:: created_at

The timestamp of when the secret was created

.. attribute:: updated_at

The timestamp of when the secret was last updated
"""

class_name = "SharedOrganizationSecret"


class OrganizationSecret(_Secret):
"""An object representing am organization secret for GitHub Actions.

See https://docs.github.com/en/rest/actions/secrets for more details.
GitHub never reveals the secret value through its API, it is only accessible
from within actions. Therefore, this object represents the secret's metadata
but not its actual value.

.. attribute:: name

The name of the secret

.. attribute:: created_at

The timestamp of when the secret was created

.. attribute:: updated_at

The timestamp of when the secret was last updated
"""

class_name = "OrganizationSecret"

def _update_attributes(self, secret):
super()._update_attributes(secret)
self.visibility = secret["visibility"]
if self.visibility == "selected":
self._selected_repos_url = secret["selected_repositories_url"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the URL attribute "private"? It should be public and named identically to the value in the JSON.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I made it public and renamed it to selected_repositories_url.


def selected_repositories(self, number=-1, etag=""):
"""Iterates over all repositories this secret is visible to.

:param int number:
(optional), number of repositories to return.
Default: -1 returns all selected repositories.
:param str etag:
(optional), ETag from a previous request to the same endpoint
:returns:
Generator of selected repositories or None if the visibility of this
secret is not set to 'selected'.
:rtype:
:class:`~github3.repos.ShortRepository`
"""
from .. import repos

if self.visibility != "selected":
return None

return self._iter(
int(number),
self._selected_repos_url,
repos.ShortRepository,
etag=etag,
list_key="repositories",
)

def set_selected_repositories(self, repository_ids: typing.List[int]):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer Sequence over List as a List[int] precludes Tuple[int] or any other sequence like data that Python will happily correctly serialize to a JSON Array

"""Sets the selected repositories this secret is visible to.

:param list[int] repository_ids:
A list of repository IDs which this secret should be visible to.
:returns:
A boolean indicating whether the update was successful.
:rtype:
bool
"""
if self.visibility != "selected":
raise ValueError(
"""cannot set a list of selected repositories when visibility
is not 'selected'"""
)

data = {"selected_repository_ids": repository_ids}

return self._boolean(
self._put(self._selected_repos_url, json=data), 204, 404
)

def add_selected_repository(self, repository_id: int):
"""Adds a repository to the list of repositories this secret is
visible to.

:param int repository_id:
The IDs of a repository this secret should be visible to.
:raises:
A ValueError if the visibility of this secret is not 'selected'.
:returns:
A boolean indicating if the repository was successfully added to
the visible list.
:rtype:
bool
"""
if self.visibility != "selected":
raise ValueError(
"cannot add a repository when visibility is not 'selected'"
)

url = "/".join([self._selected_repos_url, str(repository_id)])
return self._boolean(self._put(url), 204, 409)

def delete_selected_repository(self, repository_id: int):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def delete_selected_repository(self, repository_id: int):
def remove_selected_repository(self, repository_id: int):

Alternatively

These should be:

  • select_repositories
  • select_repository
  • deselect_repository

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the method to remove_selected_repositories() but would prefer to keep the other function names are they are to be consistent with the GitHub API documentation.

"""Deletes a repository from the list of repositories this secret is
visible to.

:param int repository_id:
The IDs of the repository this secret should no longer be
visible to.
:raises:
A ValueError if the visibility of this secret is not 'selected'.
:returns:
A boolean indicating if the repository was successfully removed
from the visible list.
:rtype:
bool
"""
if self.visibility != "selected":
raise ValueError(
"cannot delete a repository when visibility is not 'selected'"
)

url = "/".join([self._selected_repos_url, str(repository_id)])
return self._boolean(self._delete(url), 204, 409)
Loading
Loading