Update Infoflow and CapDL proofs for explicit fpu changes #891
+436
−273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corlewis
approved these changes
Apr 22, 2025
Comment on lines
+158
to
+159
| crunch arch_prepare_set_domain | ||
| for inv[IRQMasks_IF_assms,wp]: P |
There was a problem hiding this comment.
It looks like this is proved both here and in ArchFinalCaps. I'm not sure what the imports look like and they might make it hard, but it would be nice not to introduce more duplication.
There was a problem hiding this comment.
There wasn't a simple common ancestor. I'll have another look.
There was a problem hiding this comment.
IRQMasks_IF imports Access.ArchDomainSepInv and is used after FinalCaps. I could change dependencies, but maybe not ideal?
lsf37
approved these changes
Apr 22, 2025
|
Are we expecting DPolicy to pass in this one? There were changes in that file, IIRC. |
Think it only works after my access changes, will remove here |
ryybrr
force-pushed
the
ryanb_explicit_fpu
branch
from
14aac05 to
8e5732d
Compare
corlewis
force-pushed
the
explicit_fpu_other_arches
branch
2 times, most recently
from
fcb1d21 to
fe8bef4
Compare
Signed-off-by: Ryan Barry <ryan.barry@proofcraft.systems>
Signed-off-by: Ryan Barry <ryan.barry@proofcraft.systems>
Signed-off-by: Ryan Barry <ryan.barry@proofcraft.systems>
Signed-off-by: Corey Lewis <corey.lewis@proofcraft.systems>
ryybrr
force-pushed
the
ryanb_explicit_fpu
branch
from
8e5732d to
505a1c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix breakages up the proof stack for ARM and RISCV64
Test with seL4/seL4#1325