Skip to content

Fixes #298: Repeatedly appending parent path to flatFiles #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mayank-singh-sikarwar
Copy link

@mayank-singh-sikarwar mayank-singh-sikarwar commented Apr 29, 2025

Purpose: Fix for appending parent path to CSV file paths in cosmx.py reader module.

@mayank-singh-sikarwar mayank-singh-sikarwar marked this pull request as draft April 29, 2025 09:58
@mayank-singh-sikarwar mayank-singh-sikarwar marked this pull request as ready for review April 29, 2025 09:59
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.48%. Comparing base (296d9a5) to head (cb147e2).
Report is 174 commits behind head on main.

Files with missing lines Patch % Lines
src/spatialdata_io/readers/cosmx.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #305       +/-   ##
===========================================
+ Coverage   39.16%   49.48%   +10.31%     
===========================================
  Files          26       26               
  Lines        2663     2712       +49     
===========================================
+ Hits         1043     1342      +299     
+ Misses       1620     1370      -250     
Files with missing lines Coverage Δ
src/spatialdata_io/readers/cosmx.py 18.51% <0.00%> (-0.43%) ⬇️

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants