-
-
Notifications
You must be signed in to change notification settings - Fork 47
Add insert_pytest_raises() #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 96.27% 97.12% +0.85%
==========================================
Files 8 8
Lines 725 766 +41
Branches 110 121 +11
==========================================
+ Hits 698 744 +46
+ Misses 21 17 -4
+ Partials 6 5 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for the PR. I think I like it, please could you explain exactly how it works?
@samuelcolvin A gentle reminder to review this feature whenever you have a minute |
Every time I used insert_assert I was ecstatic with my new productivity but something was missing: it was always painful to catch and match exceptions. Only recently have I realized that same tooling and approach could be used to solve that problem as well.
Note that this is only a working prototype without tests or proper structure/naming.
If you like the idea -- I'll be happy to provide the rest :)