SNP Integration Test: Improve Clarity #1621
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
force-pushed
the
snp-test
branch
2 times, most recently
from
ca3266b to
e24e342
Compare
phip1611
changed the title
phip1611
force-pushed
the
snp-test
branch
2 times, most recently
from
6c758f5 to
ff20426
Compare
|
FYI: I wouldn't count on interrupt status returning anything useful. I'm actually somewhat surprised to find this in the SNP spec (without much details what the expected behavior is). UEFI does not use interrupts (except timer) and handles devices in polling mode. So there is little reason for uefi drivers to configure device interrupt registers in the first place. |
phip1611
force-pushed
the
snp-test
branch
4 times, most recently
from
56f24c9 to
ad4b06f
Compare
Interestingly, the interrupt status never shows that we can receive a packet. Buggy OVMF firmware?
This helps to identify the network interface in integration tests. So far, we also only use a single network device. In case there are more, the next device should have a similar MAC address, such as the last component being incremented by one.
2 tasks
| @@ -186,13 +186,36 @@ impl SimpleNetwork { | |||
| status.to_result_with_val(|| NonNull::new(tx_buf.cast())) | |||
| } | |||
|
|
|||
| /// Place a packet in the transmit queue of a network interface. | |||
| /// Place a packet in the transmit queue of the network interface. | |||
There was a problem hiding this comment.
Could the changes in this file be moved to a separate PR? I'd like to review them in isolation from the test changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: This adds more clarity to facilitate future debugging and improvements for #1617.
Wow, this was an unexpected major time sink. The problem here is that if
snp::testruns beforepxe::test,snp.receive()receives an Ethernet ARP package rather than a Ethernet IPv4 packet.I tried two solutions:
I got non working, unfortunately. So instead, this adds more clarity to ease future debugging and improvements.
Relates to #1617 opened by @kraxel.
Checklist