-
-
Notifications
You must be signed in to change notification settings - Fork 250
Add React interopt guide #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nojaf is attempting to deploy a commit to the ReScript Association Team on Vercel. A member of the Team first needs to authorize it. |
@fhammerschmidt any thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider wrapping your examples in <CodeTab>
s and format them in the playground. Then you can also grab the JS output from there (usually without the noise of imports, many such examples can be found in the codebase).
Also I am currently working on compiling the React examples in tests, so would be nice if you ensure they actually compile in the playground. No need for them to execute though. |
Thanks @fhammerschmidt, this is great feedback! |
I just had a look at an old PR which basically does the same thing as you here, but they named the chapter Can you steal the naming from there and do what @ryyppy mentioned in his last reply?
|
Alright, done! |
Superb! |
These are some notes on importing existing React components.