Migrate to Core #876
Migrate to Core #876
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/SearchBox.res
Outdated
| // TODO(aspeddro) | ||
| // let isDiv = Js.Null_undefined.isNullable(el["type"]) | ||
| let isDiv = Nullable.toOption(el["type"])->Option.isSome |
There was a problem hiding this comment.
I think Option.isSome is alternative to Js.Null_undefined.isNullable, right?
There was a problem hiding this comment.
not really, as it is not optimized by the compiler in the null case
I am not really sure why this did not make it into Core, @zth ?
There was a problem hiding this comment.
Js.Null_undefined.isNullable
There was a problem hiding this comment.
it's just
external isNullable: t<'a> => bool = "#is_nullable"
There was a problem hiding this comment.
Ah, probably just a miss. Care to PR it?
There was a problem hiding this comment.
Yes. I Opened a PR on Core. I'll leave Js.Null_undefined.isNullable until a new version of Core is released
| let focusInput = () => | ||
| input.current | ||
| ->Js.Nullable.toOption | ||
| ->Belt.Option.forEach(input => input->focus) | ||
| ->Nullable.toOption |
There was a problem hiding this comment.
there is also Nullable.forEach now
|
|
||
| let onClick = _ => { | ||
| inputEl.current | ||
| ->Js.Nullable.toOption | ||
| ->Belt.Option.forEach(input => input->focus) | ||
| ->Nullable.toOption |
| let setTextInputRef = element => { | ||
| textInput.current = element; | ||
| } | ||
|
|
||
| let focusTextInput = _ => { | ||
| textInput.current | ||
| ->Js.Nullable.toOption | ||
| ->Belt.Option.forEach(input => input->focus) | ||
| ->Nullable.toOption |
|
|
||
| let focusInput = () => | ||
| switch textInput.current->Js.Nullable.toOption { | ||
| switch textInput.current->Nullable.toOption { |
There was a problem hiding this comment.
no need to convert to option anymore, just pattern-match directly:
switch textInput.current {
| Value(dom) => dom->focus
| Null | Undefined => ()
}| let setTextInputRef = element => { | ||
| textInput.current = element; | ||
| } | ||
|
|
||
| let focusTextInput = _ => { | ||
| textInput.current | ||
| ->Js.Nullable.toOption | ||
| ->Belt.Option.forEach(input => input->focus) | ||
| ->Nullable.toOption |
src/ApiDocs.res
Outdated
| </div> | ||
| <div className="hl-overline text-gray-80 mt-5 mb-2"> {"submodules"->React.string} </div> | ||
| {node.children | ||
| ->Js.Array2.sortInPlaceWith((v1, v2) => v1.name > v2.name ? 1 : -1) | ||
| ->Js.Array2.map(renderNode) | ||
| ->Belt.SortArray.stableSortBy((v1, v2) => v1.name > v2.name ? 1 : -1) |
There was a problem hiding this comment.
Array.toSorted might be sufficient here?
src/Packages.res
Outdated
| @@ -102,7 +100,7 @@ module Resource = { | |||
|
|
|||
| fuser | |||
| ->Fuse.search(pattern) | |||
| ->Js.Array2.sortInPlaceWith((a, b) => a["item"].searchScore > b["item"].searchScore ? -1 : 1) | |||
| ->Belt.SortArray.stableSortBy((a, b) => a["item"].searchScore > b["item"].searchScore ? -1 : 1) | |||
There was a problem hiding this comment.
again, Array.toSorted is good enough
|
|
No description provided.