Compatibility fixes #41
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunchr
approved these changes
Feb 4, 2025
Comment on lines
-7
to
+9
| config.assets.precompile += %w[hotsheet/application.css hotsheet/application.js] | ||
| initializer "hotsheet.assets" do |app| | ||
| app.config.assets.precompile += %w[hotsheet/application.css hotsheet/application.js] | ||
| end |
There was a problem hiding this comment.
It would use the "installer" apps to precompile hotsheet assets, instead of the gem having it's own
|
This is still incomplete, sorry I didn't create it as Draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support only sprockets projects, in this MR I intend to get rid of that dependency and allow other tools such as CSS/JS bundling and importmaps