createClient url+tls invariant violation check #2835
+82
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on url
rediss:..
+ tls: false passed or on url:redis:
+ rls: true passed, the lib blows up during connection with a non-descriptive errorI explicitly check for this invariant violation during initialisation
this.#selectedDB = options.database;
in#initiateOptions
I dare not to touchtls
(it did this anyways, implicitly, by blowing up the connection on wrong tls passed)#initiateOptions
was implemented (let me know if you'd like me to not-mutate the argument; I'd actually prefer it this way)tls
explicitly to boolean if it wasn't set but anurl
was passed: reasons are both technical (I needed to test without changing your interfaces much) and logical:tls
undefined with URL:redis[s]:
seems to be an incorrect invariant anywaysOptions:
Checklist
npm test
pass with this change (including linting)?