Skip to content

fix: content not visible on js version #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Jun 20, 2023

Overview

This fixes the appearance of the JS version of the segmented control

screenshots

before

Screenshot_1687268903

after

Screenshot_1687269144

Test Plan

I'm not able to test because I'm not able to start up the example app in this repo, but tested this elsewhere

@vonovak vonovak requested a review from Naturalclar as a code owner June 20, 2023 13:54
@Naturalclar
Copy link
Member

currently organizing stuff around ci and example project.
will look at the pr afterwards 🙏

@Saadnajmi
Copy link
Contributor

Hey @Naturalclar , I noticed the datetimepicker repo still has a patch to add this fix to segmented-control in their example app. Would you mind if I remade this PR to perhaps remove the need for the patch?

@Naturalclar
Copy link
Member

@Saadnajmi sure! That would help out alot!
Sorry for not being able to keep up with the maintenance 🙏

@Saadnajmi
Copy link
Contributor

Saadnajmi commented Apr 18, 2024

@Saadnajmi sure! That would help out alot! Sorry for not being able to keep up with the maintenance 🙏

No worries, you maintain a lot! (How much stuff exactly? 😅) Happy to help out when/where I can, even if entirely motivated by code I'm currently touching haha. #848

@Naturalclar
Copy link
Member

even if entirely motivated by code I'm currently touching haha

Thats like the only time im motivated to touch codes as well haha
Unfortunately i havent been in need for this component in a while..

@Saadnajmi
Copy link
Contributor

@vonovak looks like you can close this now. I'll update my PR to datetiimepicker to remove the patch and pull the new version

@Naturalclar
Copy link
Member

released in v2.5.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants