-
Notifications
You must be signed in to change notification settings - Fork 77
Feature: Join Latest #874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature: Join Latest #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
324243e
to
795f95f
Compare
Related to #484 |
Write the stored value back to cache if the cache is empty
Exit early if the key falls below the lower bound
- Moved the join logic to the separate class - Added separate registration for TimestampedStore
gwaramadze
commented
May 19, 2025
gwaramadze
commented
May 19, 2025
* Serialize unsigned (only positive) integers * Import int_to_int64_bytes from a correct module * Move encode_integer_pair to a common serialization module * Move test_encode_integer_pair * Append zero to timestamped store keys * Add small comment to test * Rename int serialization functions
ovv
previously approved these changes
May 21, 2025
gwaramadze
commented
May 21, 2025
Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
Co-authored-by: Remy Gwaramadze <gwaramadze@users.noreply.github.com>
ovv
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.