Skip to content

Update .git-blame-ignore-revs for test return types. #7332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2025

Conversation

dstrain115
Copy link
Collaborator

This adds a ignore line for PR #7327, which adds the return type for many tests.

@dstrain115 dstrain115 requested review from vtomole and a team as code owners May 12, 2025 23:33
@dstrain115 dstrain115 requested a review from maffoo May 12, 2025 23:33
@github-actions github-actions bot added the Size: XS <10 lines changed label May 12, 2025
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (651fefa) to head (594b5a6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7332   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files        1111     1111           
  Lines       96831    96831           
=======================================
+ Hits        95547    95548    +1     
+ Misses       1284     1283    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines 31 to 32
# Format proto files (#7133)
5cf0e8df8f3e097b8d496cba1c2d4bd04cb83546
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title states this is to ignore #7327, but the commit here is for #7133.
Should both of these PRs be ignored or just #7327? Please sync.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, had a cut and paste issue. Changed the description to reference the actual issue.

Copy link
Collaborator

@pavoljuhas pavoljuhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the PR title / description for the actual change.

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dstrain115 dstrain115 added this pull request to the merge queue May 14, 2025
Merged via the queue into quantumlib:main with commit 22b4831 May 14, 2025
39 checks passed
@dstrain115 dstrain115 deleted the blame_ignore_adding_tests branch May 14, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants